chore: enable errorlint (#774)

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -7,6 +7,7 @@ run:
 linters:
   enable:
     - errcheck
+    - errorlint
     - misspell
 
   settings:
@@ -29,3 +30,9 @@ formatters:
   settings:
     gofumpt:
       extra-rules: true
+
+issues:
+  # Maximum issues count per one linter.
+  max-issues-per-linter: 0
+  # Maximum count of issues with the same text.
+  max-same-issues: 0

interceptors/client.go

@@ -7,6 +7,7 @@ package interceptors
 
 import (
 	"context"
+	"errors"
 	"io"
 	"time"
 
@@ -68,7 +69,7 @@ func (s *monitoredClientStream) RecvMsg(m any) error {
 			return nil
 		}
 		var postErr error
-		if err != io.EOF {
+		if !errors.Is(err, io.EOF) {
 			postErr = err
 		}
 		s.reporter.PostCall(postErr, time.Since(s.startTime))

interceptors/client_test.go

@@ -5,6 +5,7 @@ package interceptors
 
 import (
 	"context"
+	"errors"
 	"io"
 	"net"
 	"sync"
@@ -249,7 +250,7 @@ func (s *ClientInterceptorTestSuite) TestListReporting() {
 	count := 0
 	for {
 		_, err := ss.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "reading pingList shouldn't fail")
@@ -305,7 +306,7 @@ func (s *ClientInterceptorTestSuite) TestBiStreamingReporting() {
 		for s.ctx.Err() == nil {
 
 			_, err := ss.Recv()
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				break
 			}
 			if !s.Assert().NoError(err, "reading pingStream shouldn't fail") {

interceptors/logging/interceptors.go

@@ -5,6 +5,7 @@ package logging
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"time"
@@ -31,7 +32,7 @@ func (c *reporter) PostCall(err error, duration time.Duration) {
 	if !has(c.opts.loggableEvents, FinishCall) {
 		return
 	}
-	if err == io.EOF {
+	if errors.Is(err, io.EOF) {
 		err = nil
 	}
 

interceptors/logging/interceptors_test.go

@@ -7,6 +7,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"runtime"
@@ -283,7 +284,7 @@ func (s *loggingClientServerSuite) TestPingList() {
 	require.NoError(s.T(), err, "should not fail on establishing the stream")
 	for {
 		_, err := stream.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "reading stream should not fail")
@@ -468,7 +469,7 @@ func (s *loggingCustomDurationSuite) TestPingList_HasOverriddenDuration() {
 	require.NoError(s.T(), err, "should not fail on establishing the stream")
 	for {
 		_, err := stream.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "reading stream should not fail")
@@ -754,7 +755,7 @@ func (s *loggingCustomGrpcLogFieldsSuite) TestCustomGrpcLogFieldsWithPingList()
 	require.NoError(s.T(), err, "should not fail on establishing the stream")
 	for {
 		_, err := stream.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "reading stream should not fail")

interceptors/retry/examples_test.go

@@ -5,6 +5,7 @@ package retry
 
 import (
 	"context"
+	"errors"
 	"io"
 	"time"
 
@@ -58,7 +59,7 @@ func Example_simpleCall() {
 
 	for {
 		_, err := stream.Recv() // retries happen here
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		} else if err != nil {
 			return

interceptors/retry/retry.go

@@ -5,6 +5,7 @@ package retry
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"sync"
@@ -213,7 +214,7 @@ func (s *serverStreamingRetryingStream) RecvMsg(m any) error {
 
 func (s *serverStreamingRetryingStream) receiveMsgAndIndicateRetry(m any) (bool, error) {
 	err := s.getStream().RecvMsg(m)
-	if err == nil || err == io.EOF {
+	if err == nil || errors.Is(err, io.EOF) {
 		return false, err
 	}
 	if isContextError(err) {
@@ -308,10 +309,10 @@ func perStreamContext(parentCtx context.Context, callOpts *options, attempt uint
 }
 
 func contextErrToGrpcErr(err error) error {
-	switch err {
-	case context.DeadlineExceeded:
+	switch {
+	case errors.Is(err, context.DeadlineExceeded):
 		return status.Error(codes.DeadlineExceeded, err.Error())
-	case context.Canceled:
+	case errors.Is(err, context.Canceled):
 		return status.Error(codes.Canceled, err.Error())
 	default:
 		return status.Error(codes.Unknown, err.Error())

interceptors/retry/retry_test.go

@@ -5,6 +5,7 @@ package retry
 
 import (
 	"context"
+	"errors"
 	"io"
 	"strconv"
 	"strings"
@@ -299,7 +300,7 @@ func (s *RetrySuite) assertPingListWasCorrect(stream testpb.TestService_PingList
 	count := 0
 	for {
 		pong, err := stream.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "no errors during receive on client side")

interceptors/server_test.go

@@ -5,6 +5,7 @@ package interceptors
 
 import (
 	"context"
+	"errors"
 	"io"
 	"net"
 	"sync"
@@ -111,7 +112,7 @@ func (s *ServerInterceptorTestSuite) TestStreamingReports() {
 	count := 0
 	for {
 		_, err := ss.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		require.NoError(s.T(), err, "reading pingList shouldn't fail")
@@ -153,7 +154,7 @@ func (s *ServerInterceptorTestSuite) TestBiStreamingReporting() {
 		for s.ctx.Err() == nil {
 
 			_, err := ss.Recv()
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				break
 			}
 			require.NoError(s.T(), err, "reading pingStream shouldn't fail")

interceptors/validator/interceptors_test.go

@@ -5,6 +5,7 @@ package validator_test
 
 import (
 	"context"
+	"errors"
 	"io"
 	"testing"
 
@@ -38,7 +39,7 @@ func (s *ValidatorTestSuite) TestValidPasses_ServerStream() {
 	require.NoError(s.T(), err, "no error on stream establishment expected")
 	for {
 		_, err := stream.Recv()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		assert.NoError(s.T(), err, "no error on messages sent occurred")