chore: enable several rules from go-critic (#766)

* chore: enable-all rules from go-critic

Signed-off-by: Matthieu MOREL <[email protected]>

* chore: enable httpNoBody from go-critic

Signed-off-by: Matthieu MOREL <[email protected]>

* chore: enable assignOp rule from go-critic

Signed-off-by: Matthieu MOREL <[email protected]>

* chore: enable commentedOutCode rule from go-critic

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -8,6 +8,7 @@ linters:
   enable:
     - errcheck
     - errorlint
+    - gocritic
     - misspell
     - testifylint
 
@@ -16,6 +17,17 @@ linters:
       exclude-functions:
         - (github.com/go-kit/log.Logger).Log
 
+    gocritic:
+      disabled-checks:
+        - appendAssign
+        - builtinShadow
+        - deferInLoop
+        - exitAfterDefer
+        - hugeParam
+        - importShadow
+        - unnamedResult
+      enable-all: true
+
     testifylint:
       disable:
         - go-require

interceptors/realip/realip.go

@@ -81,7 +81,7 @@ func ipFromHeaders(ctx context.Context, headers []string, trustedProxies []netip
 		a := strings.Split(getHeader(ctx, header), ",")
 		idx := len(a) - 1
 		if header == XForwardedFor {
-			idx = idx - int(trustedProxyCnt)
+			idx -= int(trustedProxyCnt)
 			if idx < 0 {
 				continue
 			}

providers/prometheus/server_test.go

@@ -175,7 +175,7 @@ func (s *ServerInterceptorTestSuite) TestContextCancelledTreatedAsStatus() {
 // Order of matching label vales does not matter.
 func fetchPrometheusLines(t *testing.T, reg prometheus.Gatherer, metricName string, matchingLabelValues ...string) []string {
 	resp := httptest.NewRecorder()
-	req, err := http.NewRequest("GET", "/", nil)
+	req, err := http.NewRequest("GET", "/", http.NoBody)
 	require.NoError(t, err, "failed creating request for Prometheus handler")
 
 	promhttp.HandlerFor(reg, promhttp.HandlerOpts{}).ServeHTTP(resp, req)

testing/testpb/interceptor_suite.go

@@ -188,7 +188,6 @@ func ExtractErrorFields(err error) []any {
 // UnaryServerInterceptor returns a new unary server interceptors that adds query information logging.
 func UnaryServerInterceptor() grpc.UnaryServerInterceptor {
 	return func(ctx context.Context, req any, _ *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (any, error) {
-		// newCtx := newContext(ctx, log, opts)
 		newCtx := ctx
 		resp, err := handler(newCtx, req)
 		return resp, err