Skip to content

Commit f6f8eae

Browse files
authored
Fix InitializeMetrics signature to allow use with xds.GRPCServer (#689)
1 parent a776860 commit f6f8eae

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

providers/prometheus/server_metrics.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors"
88
"github.com/prometheus/client_golang/prometheus"
99
"google.golang.org/grpc"
10+
"google.golang.org/grpc/reflection"
1011
)
1112

1213
// ServerMetrics represents a collection of metrics to be registered on a
@@ -81,7 +82,7 @@ func (m *ServerMetrics) Collect(ch chan<- prometheus.Metric) {
8182
// value, for all gRPC methods registered on a gRPC server. This is useful, to
8283
// ensure that all metrics exist when collecting and querying.
8384
// NOTE: This might add significant cardinality and might not be needed in future version of Prometheus (created timestamp).
84-
func (m *ServerMetrics) InitializeMetrics(server *grpc.Server) {
85+
func (m *ServerMetrics) InitializeMetrics(server reflection.ServiceInfoProvider) {
8586
serviceInfo := server.GetServiceInfo()
8687
for serviceName, info := range serviceInfo {
8788
for _, mInfo := range info.Methods {

0 commit comments

Comments
 (0)