Skip to content

Update README.md - re metric names inherited from https://github.com/grpc-ecosystem/go-grpc-prometheus #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md - re metric names inherited from https://github.com/grpc-ecosystem/go-grpc-prometheus #651

wants to merge 2 commits into from

Conversation

bwplotka
Copy link
Collaborator

@bwplotka bwplotka commented Oct 3, 2023

Thanks @brancz for reminding us to mention this in docs!

brancz
brancz approved these changes Oct 3, 2023
View reviewed changes
Copy link

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for double checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst Awaiting requested review from johanbrandhorst

1 more reviewer

@brancz brancz brancz approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwplotka @brancz