Skip to content

Commit 04a7ec4

Browse files
feat(gen-openapiv2): support trailing comments (#2965)
* feat(gen-openapiv2): support trailing comments * feat(gen-openapiv2): add examplepb for trailing comments * fix typo Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]> * fix indent * fix: regenerate the example files Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
1 parent a5d1e9d commit 04a7ec4

14 files changed

+1760
-733
lines changed

examples/internal/clients/abe/api/swagger.yaml

Lines changed: 345 additions & 0 deletions
Large diffs are not rendered by default.

examples/internal/clients/abe/api_a_bit_of_everything_service.go

Lines changed: 180 additions & 0 deletions
Large diffs are not rendered by default.

examples/internal/clients/abe/model_a_bit_of_everything.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,11 @@ type ABitOfEverything struct {
6565
RequiredStringField2 string `json:"requiredStringField2"`
6666
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom"`
6767
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom"`
68+
TrailingOnly string `json:"trailingOnly,omitempty"`
69+
// Trailing only dot.
70+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
71+
// Trailing both.
72+
TrailingBoth string `json:"trailingBoth,omitempty"`
73+
// This is an example of a multi-line comment. Trailing multiline.
74+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6875
}

examples/internal/clients/abe/model_a_bit_of_everything_1.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,11 @@ type ABitOfEverything1 struct {
6666
RequiredStringField2 string `json:"requiredStringField2"`
6767
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom"`
6868
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom"`
69+
TrailingOnly string `json:"trailingOnly,omitempty"`
70+
// Trailing only dot.
71+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
72+
// Trailing both.
73+
TrailingBoth string `json:"trailingBoth,omitempty"`
74+
// This is an example of a multi-line comment. Trailing multiline.
75+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6976
}

examples/internal/clients/abe/model_a_bit_of_everything_2.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,11 @@ type ABitOfEverything2 struct {
6565
RequiredStringField2 string `json:"requiredStringField2"`
6666
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom"`
6767
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom"`
68+
TrailingOnly string `json:"trailingOnly,omitempty"`
69+
// Trailing only dot.
70+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
71+
// Trailing both.
72+
TrailingBoth string `json:"trailingBoth,omitempty"`
73+
// This is an example of a multi-line comment. Trailing multiline.
74+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6875
}

examples/internal/clients/abe/model_a_bit_of_everything_3.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,11 @@ type ABitOfEverything3 struct {
6565
RequiredStringField2 string `json:"requiredStringField2"`
6666
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom"`
6767
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom"`
68+
TrailingOnly string `json:"trailingOnly,omitempty"`
69+
// Trailing only dot.
70+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
71+
// Trailing both.
72+
TrailingBoth string `json:"trailingBoth,omitempty"`
73+
// This is an example of a multi-line comment. Trailing multiline.
74+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6875
}

examples/internal/clients/abe/model_a_bit_of_everything_4.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,11 @@ type ABitOfEverything4 struct {
6565
RequiredStringField2 string `json:"requiredStringField2,omitempty"`
6666
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom,omitempty"`
6767
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom,omitempty"`
68+
TrailingOnly string `json:"trailingOnly,omitempty"`
69+
// Trailing only dot.
70+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
71+
// Trailing both.
72+
TrailingBoth string `json:"trailingBoth,omitempty"`
73+
// This is an example of a multi-line comment. Trailing multiline.
74+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6875
}

examples/internal/clients/abe/model_examplepb_a_bit_of_everything.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,11 @@ type ExamplepbABitOfEverything struct {
6666
RequiredStringField2 string `json:"requiredStringField2"`
6767
RequiredFieldBehaviorJsonNameCustom string `json:"required_field_behavior_json_name_custom"`
6868
RequiredFieldSchemaJsonNameCustom string `json:"required_field_schema_json_name_custom"`
69+
TrailingOnly string `json:"trailingOnly,omitempty"`
70+
// Trailing only dot.
71+
TrailingOnlyDot string `json:"trailingOnlyDot,omitempty"`
72+
// Trailing both.
73+
TrailingBoth string `json:"trailingBoth,omitempty"`
74+
// This is an example of a multi-line comment. Trailing multiline.
75+
TrailingMultiline string `json:"trailingMultiline,omitempty"`
6976
}

examples/internal/proto/examplepb/a_bit_of_everything.pb.go

Lines changed: 780 additions & 733 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/internal/proto/examplepb/a_bit_of_everything.proto

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,15 @@ message ABitOfEverything {
406406
(google.api.field_behavior) = REQUIRED
407407
];
408408
string required_field_schema_json_name = 46 [json_name = "required_field_schema_json_name_custom"];
409+
410+
string trailing_only = 47; // Trailing only
411+
string trailing_only_dot = 48; // Trailing only dot.
412+
// Leading both
413+
string trailing_both = 49; // Trailing both.
414+
// Leading multiline
415+
//
416+
// This is an example of a multi-line comment.
417+
string trailing_multiline = 50; // Trailing multiline.
409418
}
410419

411420
// ABitOfEverythingRepeated is used to validate repeated path parameter functionality

0 commit comments

Comments
 (0)