CI: fix release builds (#884)

* CI: fix release builds

* Solve resty issue once and for all with sed magic

Author: johanbrandhorst

.circleci/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:latest
+FROM golang:1.11
 
 ## Warm apt cache
 RUN apt-get update
@@ -26,11 +26,6 @@ RUN apt-get install -y wget bzip2 && \
     wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash && \
     apt-get remove -y wget
 
-# Install dep
-RUN apt-get install -y wget && \
-    wget -qO- https://raw.githubusercontent.com/golang/dep/master/install.sh | sh && \
-    apt-get remove -y wget
-
 # Clean up
 RUN apt-get autoremove -y && \
     rm -rf /var/lib/apt/lists/*

.circleci/config.yml

@@ -64,8 +64,8 @@ jobs:
             EOF
       - run:
           name: Check that Bazel BUILD files are up-to-date
-          command: 'test -z "$(bazel run //:gazelle_diff)" ||
-            (echo "ERROR: Bazel files out-of-date, please run \`bazel run :gazelle_fix\`" >&2; exit 1)'
+          command: 'bazel run //:gazelle ||
+            (echo "ERROR: Bazel files out-of-date, please run \`bazel run :gazelle\`" >&2; exit 1)'
       - run:
           name: Run tests with Bazel
           command: bazel test //...

CONTRIBUTING.md

@@ -29,7 +29,7 @@ docker run -v $(pwd):/src/grpc-gateway --rm jfbrandhorst/grpc-gateway-build-env
         make realclean && \
         make examples SWAGGER_CODEGEN="${SWAGGER_CODEGEN}"'
 docker run -itv $(pwd):/grpc-gateway -w /grpc-gateway --entrypoint /bin/bash --rm \
-    l.gcr.io/google/bazel -c 'bazel run :gazelle_fix; bazel run :buildifier'
+    l.gcr.io/google/bazel -c 'bazel run :gazelle; bazel run :buildifier'
 ```
 
 If this has resulted in some file changes in the repo, please ensure you check those in with your merge request.

Makefile

@@ -177,6 +177,7 @@ $(RESPONSE_BODY_EXAMPLE_SRCS): $(RESPONSE_BODY_EXAMPLE_SPEC)
 		$(EXAMPLE_CLIENT_DIR)/responsebody/git_push.sh
 
 examples: $(EXAMPLE_DEPSRCS) $(EXAMPLE_SVCSRCS) $(EXAMPLE_GWSRCS) $(EXAMPLE_SWAGGERSRCS) $(EXAMPLE_CLIENT_SRCS)
+	find -type f -name *.go -exec sed -s -i 's;github.com/go-resty/resty;gopkg.in/resty.v1;g' {} +
 test: examples
 	go test -race ...
 	go test -race examples/integration -args -network=unix -endpoint=test.sock

WORKSPACE

@@ -21,12 +21,10 @@ go_rules_dependencies()
 
 go_register_toolchains()
 
-load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
+load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository")
 
 gazelle_dependencies()
 
-load("@bazel_gazelle//:deps.bzl", "go_repository")
-
 # Also define in Gopkg.toml
 go_repository(
     name = "org_golang_google_genproto",
@@ -43,9 +41,9 @@ go_repository(
 
 # Also define in Gopkg.toml
 go_repository(
-    name = "com_github_go_resty_resty",
-    commit = "f8815663de1e64d57cdd4ee9e2b2fa96977a030e",
-    importpath = "github.com/go-resty/resty",
+    name = "in_gopkg_resty_v1",
+    commit = "fa5875c0caa5c260ab78acec5a244215a730247f",
+    importpath = "gopkg.in/resty.v1",
 )
 
 # Also define in Gopkg.toml

examples/clients/abe/BUILD.bazel

@@ -30,6 +30,6 @@ go_library(
         "//examples/proto/examplepb:go_default_library",
         "//examples/proto/pathenum:go_default_library",
         "//runtime:go_default_library",
-        "@com_github_go_resty_resty//:go_default_library",
+        "@in_gopkg_resty_v1//:go_default_library",
     ],
 )

examples/clients/abe/api_client.go

@@ -18,7 +18,7 @@ import (
 	"strings"
 	"net/url"
 	"io/ioutil"
-	"github.com/go-resty/resty"
+	"gopkg.in/resty.v1"
 )
 
 type APIClient struct {

examples/clients/echo/BUILD.bazel

@@ -13,5 +13,5 @@ go_library(
         "examplepb_simple_message.go",
     ],
     importpath = "github.com/grpc-ecosystem/grpc-gateway/examples/clients/echo",
-    deps = ["@com_github_go_resty_resty//:go_default_library"],
+    deps = ["@in_gopkg_resty_v1//:go_default_library"],
 )

examples/clients/echo/api_client.go

@@ -18,7 +18,7 @@ import (
 	"strings"
 	"net/url"
 	"io/ioutil"
-	"github.com/go-resty/resty"
+	"gopkg.in/resty.v1"
 )
 
 type APIClient struct {

examples/clients/responsebody/BUILD.bazel

@@ -19,5 +19,5 @@ go_library(
     ],
     importpath = "github.com/grpc-ecosystem/grpc-gateway/examples/clients/responsebody",
     visibility = ["//visibility:public"],
-    deps = ["@com_github_go_resty_resty//:go_default_library"],
+    deps = ["@in_gopkg_resty_v1//:go_default_library"],
 )