Skip to content

Commit 173f885

Browse files
authored
Upgrade protobuf to v3.15.5 (#51)
* Attempt to upgrade protobuf dep * Update googletest
1 parent 9093689 commit 173f885

File tree

2 files changed

+21
-98
lines changed

2 files changed

+21
-98
lines changed

repositories.bzl

Lines changed: 6 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@ cc_library(
9292
build_file_content = BUILD,
9393
)
9494

95-
PROTOBUF_COMMIT = "3.10.1" # Oct 29, 2019
96-
PROTOBUF_SHA256 = "6adf73fd7f90409e479d6ac86529ade2d45f50494c5c10f539226693cb8fe4f7"
95+
PROTOBUF_COMMIT = "3.15.5" # Mar 04, 2021
96+
PROTOBUF_SHA256 = "bc3dbf1f09dba1b2eb3f2f70352ee97b9049066c9040ce0c9b67fb3294e91e4b"
9797

98-
RULES_PROTO_SHA = "97d8af4dc474595af3900dd85cb3a29ad28cc313"
98+
RULES_PROTO_SHA = "97d8af4dc474595af3900dd85cb3a29ad28cc313" # Oct 31, 2019
9999
RULES_PROTO_SHA256 = "602e7161d9195e50246177e7c55b2f39950a9cf7366f74ed5f22fd45750cd208"
100100

101101
def protobuf_repositories(bind = True):
@@ -116,95 +116,17 @@ def protobuf_repositories(bind = True):
116116
],
117117
)
118118

119-
GOOGLETEST_COMMIT = "43863938377a9ea1399c0596269e0890b5c5515a"
120-
GOOGLETEST_SHA256 = "7c8ece456ad588c30160429498e108e2df6f42a30888b3ec0abf5d9792d9d3a0"
119+
GOOGLETEST_COMMIT = "703bd9caab50b139428cea1aaff9974ebee5742e" # v1.10.0: Oct 2, 2019
120+
GOOGLETEST_SHA256 = "d17b1b83a57b3933565a6d0616fe261107326d47de20288d0949ed038e1c342d"
121121

122122
def googletest_repositories(bind = True):
123-
BUILD = """
124-
# Copyright 2016 Google Inc. All Rights Reserved.
125-
#
126-
# Licensed under the Apache License, Version 2.0 (the "License");
127-
# you may not use this file except in compliance with the License.
128-
# You may obtain a copy of the License at
129-
#
130-
# http://www.apache.org/licenses/LICENSE-2.0
131-
#
132-
# Unless required by applicable law or agreed to in writing, software
133-
# distributed under the License is distributed on an "AS IS" BASIS,
134-
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
135-
# See the License for the specific language governing permissions and
136-
# limitations under the License.
137-
#
138-
################################################################################
139-
#
140-
141-
cc_library(
142-
name = "googletest",
143-
srcs = [
144-
"googletest/src/gtest-all.cc",
145-
"googlemock/src/gmock-all.cc",
146-
],
147-
hdrs = glob([
148-
"googletest/include/**/*.h",
149-
"googlemock/include/**/*.h",
150-
"googletest/src/*.cc",
151-
"googletest/src/*.h",
152-
"googlemock/src/*.cc",
153-
]),
154-
includes = [
155-
"googlemock",
156-
"googletest",
157-
"googletest/include",
158-
"googlemock/include",
159-
],
160-
visibility = ["//visibility:public"],
161-
)
162-
163-
cc_library(
164-
name = "googletest_main",
165-
srcs = ["googlemock/src/gmock_main.cc"],
166-
visibility = ["//visibility:public"],
167-
linkopts = [
168-
"-lpthread",
169-
],
170-
deps = [":googletest"],
171-
)
172-
173-
cc_library(
174-
name = "googletest_prod",
175-
hdrs = [
176-
"googletest/include/gtest/gtest_prod.h",
177-
],
178-
includes = [
179-
"googletest/include",
180-
],
181-
visibility = ["//visibility:public"],
182-
)
183-
"""
184123
http_archive(
185-
name = "googletest_git",
124+
name = "com_google_googletest",
186125
strip_prefix = "googletest-" + GOOGLETEST_COMMIT,
187-
build_file_content = BUILD,
188126
url = "https://github.com/google/googletest/archive/" + GOOGLETEST_COMMIT + ".tar.gz",
189127
sha256 = GOOGLETEST_SHA256,
190128
)
191129

192-
if bind:
193-
native.bind(
194-
name = "googletest",
195-
actual = "@googletest_git//:googletest",
196-
)
197-
198-
native.bind(
199-
name = "googletest_main",
200-
actual = "@googletest_git//:googletest_main",
201-
)
202-
203-
native.bind(
204-
name = "googletest_prod",
205-
actual = "@googletest_git//:googletest_prod",
206-
)
207-
208130
GOOGLEAPIS_COMMIT = "1d5522ad1056f16a6d593b8f3038d831e64daeea" # Sept 03, 2020
209131
GOOGLEAPIS_SHA256 = "cd13e547cffaad217c942084fd5ae0985a293d0cce3e788c20796e5e2ea54758"
210132

test/BUILD

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ cc_test(
2626
],
2727
linkstatic = 1,
2828
deps = [
29-
"//external:googletest_main",
3029
"//src:http_template",
30+
"@com_google_googletest//:gtest_main",
3131
],
3232
)
3333

@@ -39,8 +39,8 @@ cc_test(
3939
],
4040
linkstatic = 1,
4141
deps = [
42-
"//external:googletest_main",
4342
"//src:path_matcher",
43+
"@com_google_googletest//:gtest_main",
4444
],
4545
)
4646

@@ -52,8 +52,8 @@ cc_test(
5252
],
5353
linkstatic = 1,
5454
deps = [
55-
"//external:googletest_main",
5655
"//src:path_matcher_utility",
56+
"@com_google_googletest//:gtest_main",
5757
],
5858
)
5959

@@ -64,8 +64,9 @@ cc_test(
6464
"prefix_writer_test.cc",
6565
],
6666
deps = [
67-
"//external:googletest_main",
6867
"//src:prefix_writer",
68+
"@com_google_googletest//:gtest_main",
69+
"@com_google_protobuf//:protobuf",
6970
],
7071
)
7172

@@ -76,9 +77,9 @@ cc_test(
7677
"request_weaver_test.cc",
7778
],
7879
deps = [
79-
"//external:googletest_main",
8080
"//src:request_weaver",
8181
"@com_google_absl//absl/strings",
82+
"@com_google_googletest//:gtest_main",
8283
],
8384
)
8485

@@ -105,9 +106,9 @@ cc_test(
105106
],
106107
deps = [
107108
":test_common",
108-
"//external:googletest_main",
109109
"//src:type_helper",
110110
"@com_google_googleapis//google/api:service_cc_proto",
111+
"@com_google_googletest//:gtest_main",
111112
],
112113
)
113114

@@ -117,9 +118,9 @@ cc_library(
117118
srcs = ["test_common.cc"],
118119
hdrs = ["test_common.h"],
119120
deps = [
120-
"//external:googletest",
121121
"//src:transcoder_input_stream",
122122
"@com_google_googleapis//google/api:service_cc_proto",
123+
"@com_google_googletest//:gtest",
123124
"@com_google_protobuf//:protobuf",
124125
],
125126
)
@@ -138,10 +139,10 @@ cc_library(
138139
deps = [
139140
":bookstore_cc_proto",
140141
":test_common",
141-
"//external:googletest",
142142
"//src:request_message_translator",
143143
"//src:type_helper",
144144
"@com_google_googleapis//google/api:service_cc_proto",
145+
"@com_google_googletest//:gtest",
145146
"@com_google_protobuf//:protobuf",
146147
],
147148
)
@@ -159,8 +160,8 @@ cc_test(
159160
":bookstore_cc_proto",
160161
":request_translator_test_base",
161162
":test_common",
162-
"//external:googletest_main",
163163
"//src:request_message_translator",
164+
"@com_google_googletest//:gtest_main",
164165
],
165166
)
166167

@@ -176,8 +177,8 @@ cc_test(
176177
deps = [
177178
":bookstore_cc_proto",
178179
":request_translator_test_base",
179-
"//external:googletest_main",
180180
"//src:request_stream_translator",
181+
"@com_google_googletest//:gtest_main",
181182
],
182183
)
183184

@@ -194,8 +195,8 @@ cc_test(
194195
":bookstore_cc_proto",
195196
":request_translator_test_base",
196197
":test_common",
197-
"//external:googletest_main",
198198
"//src:json_request_translator",
199+
"@com_google_googletest//:gtest_main",
199200
],
200201
)
201202

@@ -207,8 +208,8 @@ cc_test(
207208
],
208209
deps = [
209210
":test_common",
210-
"//external:googletest_main",
211211
"//src:message_reader",
212+
"@com_google_googletest//:gtest_main",
212213
],
213214
)
214215

@@ -224,10 +225,10 @@ cc_test(
224225
deps = [
225226
":bookstore_cc_proto",
226227
":test_common",
227-
"//external:googletest_main",
228228
"//src:message_reader",
229229
"//src:response_to_json_translator",
230230
"//src:type_helper",
231+
"@com_google_googletest//:gtest_main",
231232
],
232233
)
233234

@@ -239,7 +240,7 @@ cc_test(
239240
],
240241
deps = [
241242
":test_common",
242-
"//external:googletest_main",
243243
"//src:message_stream",
244+
"@com_google_googletest//:gtest_main",
244245
],
245246
)

0 commit comments

Comments
 (0)