Skip to content

Commit 0decfe0

Browse files
committed
Remove the attempt base unit for grpc_client_attempt_started metric,
to make sure the generated metrics name in the Prometheus is actually grpc_client_attempt_started_total instead of grpc_client_attempt_started_attempt_total and gets aligned with other languages (C++ for example).
1 parent 9c4f9ee commit 0decfe0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ static MetricsClientMeters newClientMetricsMeters(MeterRegistry registry) {
6969
.description(
7070
"The total number of RPC attempts started from the client side, including "
7171
+ "those that have not completed.")
72-
.baseUnit("attempt")
7372
.withRegistry(registry));
7473

7574
builder.setSentMessageSizeDistribution(DistributionSummary.builder(

0 commit comments

Comments
 (0)