Address review comments for the grpc-observability example.

Author: fengli79

examples/grpc-observability/README.md

@@ -97,7 +97,7 @@ kubectl apply -f ./examples/grpc-observability/frontend/frontend.yaml
 ## Set up the Prometheus to collect the gRPC metrics
 
 Once the frontend/backend microservices are deployed (either locally or on
-cloud), you may set up the Prometheus to start scrape the metrics from them.
+cloud), you may set up the Prometheus to start scraping the metrics from them.
 Depends on where you run the frontend/backend microservices, you may need to
 deploy the Prometheus to a proper location to be able to access them, such as,
 the same cloud, etc.
@@ -106,6 +106,7 @@ If you
 use [Google Managed Prometheus](https://cloud.google.com/stackdriver/docs/managed-prometheus),
 you may need to configure the PodMonitoring resource to tell where are endpoints
 to scrape the Prometheus metrics.
+
 ```
 kubectl apply -f ./examples/grpc-observability/pod_monitoring.yaml
 ```
@@ -118,7 +119,8 @@ server to visualize them.
 - Set up a Grafana server, deploy it to a place where can connect the Prometheus
   server as its data source.
 - Create a Grafana dashboard by importing the
-  grpc-observability/grafana/prometheus/microservices-grpc-dashboard.json file.
+  [examples/grpc-observability/grafana/prometheus/microservices-grpc-dashboard.json](http://github.com/grpc-ecosystem/grpc-spring/blob/master/examples/grpc-observability/grafana/prometheus/microservices-grpc-dashboard.json)
+  file.
 
 If you
 use [Google Managed Prometheus](https://cloud.google.com/stackdriver/docs/managed-prometheus),

examples/grpc-observability/backend/Dockerfile

@@ -1,3 +1,3 @@
 FROM eclipse-temurin:17-jdk-alpine
 COPY build/libs/backend.jar backend.jar
-ENTRYPOINT ["java","-jar","/backend.jar"]
+ENTRYPOINT ["java","-jar","/backend.jar"]

examples/grpc-observability/backend/backend.yaml

@@ -49,4 +49,4 @@ spec:
   - name: monitoring
     port: 8081
   - name: grpc
-    port: 9091
+    port: 9091

examples/grpc-observability/backend/src/main/resources/application.properties

@@ -4,4 +4,4 @@ server.port=8081
 # By default, expose on `/actuator/prometheus`.
 management.endpoints.web.exposure.include=prometheus
 # Port serves the gRPC traffic.
-grpc.server.port=9091
+grpc.server.port=9091

examples/grpc-observability/frontend/Dockerfile

@@ -1,3 +1,3 @@
 FROM eclipse-temurin:17-jdk-alpine
 COPY build/libs/frontend.jar frontend.jar
-ENTRYPOINT ["java","-jar","/frontend.jar"]
+ENTRYPOINT ["java","-jar","/frontend.jar"]

examples/grpc-observability/frontend/frontend.yaml

@@ -46,4 +46,4 @@ spec:
     app: frontend
   ports:
   - name: monitoring
-    port: 8080
+    port: 8080

examples/grpc-observability/frontend/src/main/resources/application.properties

@@ -9,4 +9,4 @@ management.endpoint.configprops.show-values=ALWAYS
 grpc.client.backend.address=static://localhost:9091
 # Teh backend service address, for kubernetes.
 # grpc.client.backend.address=dns:///backend.default.svc.cluster.local:9091
-grpc.client.backend.negotiationType=PLAINTEXT
+grpc.client.backend.negotiationType=PLAINTEXT

examples/grpc-observability/grafana/prometheus/microservices-grpc-dashboard.json

@@ -1402,4 +1402,4 @@
   "uid": "-ABC1NOTy",
   "version": 17,
   "weekStart": ""
-}
+}

examples/grpc-observability/pod_monitoring.yaml

@@ -9,4 +9,4 @@ spec:
   endpoints:
   - port: monitoring
     path: /actuator/prometheus
-    interval: 30s
+    interval: 30s

examples/grpc-observability/proto/src/main/proto/backend.proto

@@ -58,4 +58,4 @@ message BidiStreamingRequest {
 
 message BidiStreamingResponse {
   string message = 1;
-}
+}