Skip to content

Commit 45d71f9

Browse files
authored
Merge pull request #1041 from fengli79/master
Remove the `attempt` base unit for grpc_client_attempt_started metric
2 parents 9c4f9ee + 73e1903 commit 45d71f9

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/metrics/MetricsClientInstruments.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ static MetricsClientMeters newClientMetricsMeters(MeterRegistry registry) {
6969
.description(
7070
"The total number of RPC attempts started from the client side, including "
7171
+ "those that have not completed.")
72-
.baseUnit("attempt")
7372
.withRegistry(registry));
7473

7574
builder.setSentMessageSizeDistribution(DistributionSummary.builder(

grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/metrics/MetricsServerInstruments.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ static MetricsServerMeters newServerMetricsMeters(MeterRegistry registry) {
6666
builder.setServerCallCounter(Counter.builder(SERVER_CALL_STARTED)
6767
.description("The total number of RPC attempts started from the server side, including "
6868
+ "those that have not completed.")
69-
.baseUnit("call")
7069
.withRegistry(registry));
7170

7271
builder.setSentMessageSizeDistribution(DistributionSummary.builder(

0 commit comments

Comments
 (0)