Skip to content

Commit 5f74357

Browse files
committed
Fix code-review issues
1 parent 91de5f7 commit 5f74357

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

examples/cloud-grpc-client/src/main/java/net/devh/boot/grpc/examples/cloud/client/LogGrpcInterceptor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ public <ReqT, RespT> ClientCall<ReqT, RespT> interceptCall(
4848
final CallOptions callOptions,
4949
final Channel next) {
5050

51-
log.info(method.getFullMethodName());
51+
log.info("Received call to {}", method.getFullMethodName());
5252
return new ForwardingClientCall.SimpleForwardingClientCall<ReqT, RespT>(next.newCall(method, callOptions)) {
5353

5454
@Override
5555
public void sendMessage(ReqT message) {
56-
log.debug("Request message: \n{}", message.toString());
56+
log.debug("Request message: {}", message);
5757
super.sendMessage(message);
5858
}
5959

@@ -63,20 +63,20 @@ public void start(Listener<RespT> responseListener, Metadata headers) {
6363
new ForwardingClientCallListener.SimpleForwardingClientCallListener<RespT>(responseListener) {
6464
@Override
6565
public void onMessage(RespT message) {
66-
log.debug("Response message: \n{}", message.toString());
66+
log.debug("Response message: {}", message);
6767
super.onMessage(message);
6868
}
6969

7070
@Override
7171
public void onHeaders(Metadata headers) {
72-
log.debug("gRPC headers: \n{}", headers.toString());
72+
log.debug("gRPC headers: {}", headers);
7373
super.onHeaders(headers);
7474
}
7575

7676
@Override
7777
public void onClose(Status status, Metadata trailers) {
78-
log.info("Interaction ends with status: {}", status.toString());
79-
log.info("Trailers: {}", trailers.toString());
78+
log.info("Interaction ends with status: {}", status);
79+
log.info("Trailers: {}", trailers);
8080
super.onClose(status, trailers);
8181
}
8282
}, headers);

examples/local-grpc-client/src/main/java/net/devh/boot/grpc/examples/local/client/LogGrpcInterceptor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ public <ReqT, RespT> ClientCall<ReqT, RespT> interceptCall(
5050
CallOptions callOptions,
5151
Channel next) {
5252

53-
log.info(method.getFullMethodName());
53+
log.info("Received call to {}", method.getFullMethodName());
5454
return new ForwardingClientCall.SimpleForwardingClientCall<ReqT, RespT>(next.newCall(method, callOptions)) {
5555

5656
@Override
5757
public void sendMessage(ReqT message) {
58-
log.debug("Request message: \n{}", message.toString());
58+
log.debug("Request message: {}", message);
5959
super.sendMessage(message);
6060
}
6161

@@ -65,20 +65,20 @@ public void start(Listener<RespT> responseListener, Metadata headers) {
6565
new ForwardingClientCallListener.SimpleForwardingClientCallListener<RespT>(responseListener) {
6666
@Override
6767
public void onMessage(RespT message) {
68-
log.debug("Response message: \n{}", message.toString());
68+
log.debug("Response message: {}", message);
6969
super.onMessage(message);
7070
}
7171

7272
@Override
7373
public void onHeaders(Metadata headers) {
74-
log.debug("gRPC headers: \n{}", headers.toString());
74+
log.debug("gRPC headers: {}", headers);
7575
super.onHeaders(headers);
7676
}
7777

7878
@Override
7979
public void onClose(Status status, Metadata trailers) {
80-
log.info("Interaction ends with status: {}", status.toString());
81-
log.info("Trailers: {}", trailers.toString());
80+
log.info("Interaction ends with status: {}", status);
81+
log.info("Trailers: {}", trailers);
8282
super.onClose(status, trailers);
8383
}
8484
}, headers);

0 commit comments

Comments
 (0)