Skip to content

Commit bc37749

Browse files
author
Dave Syer
committed
Rebase on master
1 parent 1026133 commit bc37749

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,6 @@ allprojects { project ->
186186
}
187187
}
188188

189-
ext['micrometer.version'] = '1.10.3'
190-
191189
ext {
192190
// not explicitly needed in subprojects, as the BOM for Spring Boot sets this version
193191
micrometerVersion = dependencyManagement.importedProperties['micrometer.version']

grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientMicrometerTraceAutoConfiguration.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.micrometer.core.instrument.binder.grpc.ObservationGrpcClientInterceptor;
2828
import io.micrometer.observation.ObservationRegistry;
2929
import net.devh.boot.grpc.client.interceptor.GrpcGlobalClientInterceptor;
30-
import net.devh.boot.grpc.common.autoconfigure.GrpcCommonTraceAutoConfiguration;
3130
import net.devh.boot.grpc.common.util.InterceptorOrder;
3231

3332
/**
@@ -37,8 +36,7 @@
3736
*/
3837
@Configuration(proxyBeanMethods = false)
3938
@ConditionalOnProperty(value = "management.tracing.grpc.enabled", matchIfMissing = true)
40-
@AutoConfigureAfter(value = GrpcCommonTraceAutoConfiguration.class,
41-
name = "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration")
39+
@AutoConfigureAfter(name = "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration")
4240
@ConditionalOnBean(ObservationRegistry.class)
4341
public class GrpcClientMicrometerTraceAutoConfiguration {
4442

grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/autoconfigure/GrpcServerMicrometerTraceAutoConfiguration.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import io.grpc.ServerInterceptor;
2727
import io.micrometer.core.instrument.binder.grpc.ObservationGrpcServerInterceptor;
2828
import io.micrometer.observation.ObservationRegistry;
29-
import net.devh.boot.grpc.common.autoconfigure.GrpcCommonTraceAutoConfiguration;
3029
import net.devh.boot.grpc.common.util.InterceptorOrder;
3130
import net.devh.boot.grpc.server.interceptor.GrpcGlobalServerInterceptor;
3231

@@ -37,8 +36,7 @@
3736
*/
3837
@Configuration(proxyBeanMethods = false)
3938
@ConditionalOnProperty(value = "management.tracing.grpc.enabled", matchIfMissing = true)
40-
@AutoConfigureAfter(value = GrpcCommonTraceAutoConfiguration.class,
41-
name = "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration")
39+
@AutoConfigureAfter(name = "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration")
4240
@ConditionalOnBean(ObservationRegistry.class)
4341
public class GrpcServerMicrometerTraceAutoConfiguration {
4442

tests/src/test/java/net/devh/boot/grpc/test/interceptor/DefaultServerInterceptorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
import io.grpc.ServerInterceptor;
3636
import io.micrometer.core.instrument.binder.grpc.MetricCollectingServerInterceptor;
37+
import io.micrometer.core.instrument.binder.grpc.ObservationGrpcServerInterceptor;
3738
import net.devh.boot.grpc.server.interceptor.GlobalServerInterceptorRegistry;
3839
import net.devh.boot.grpc.server.scope.GrpcRequestScope;
3940
import net.devh.boot.grpc.server.security.interceptors.AuthenticatingServerInterceptor;
@@ -63,6 +64,7 @@ void testOrderingOfTheDefaultInterceptors() {
6364
final List<ServerInterceptor> expected = new ArrayList<>();
6465
expected.add(this.applicationContext.getBean(GrpcRequestScope.class));
6566
expected.add(this.applicationContext.getBean(MetricCollectingServerInterceptor.class));
67+
expected.add(this.applicationContext.getBean(ObservationGrpcServerInterceptor.class));
6668
expected.add(this.applicationContext.getBean(ExceptionTranslatingServerInterceptor.class));
6769
expected.add(this.applicationContext.getBean(AuthenticatingServerInterceptor.class));
6870
expected.add(this.applicationContext.getBean(AuthorizationCheckingServerInterceptor.class));

0 commit comments

Comments
 (0)