Skip to content

Commit f9d6756

Browse files
authored
Merge branch 'master' into feature/log-call-credential-selection
2 parents 283cb6d + ee98a42 commit f9d6756

File tree

2 files changed

+34
-11
lines changed

2 files changed

+34
-11
lines changed

grpc-client-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientAutoConfiguration.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import io.grpc.DecompressorRegistry;
3636
import io.grpc.NameResolverProvider;
3737
import io.grpc.NameResolverRegistry;
38+
import lombok.extern.slf4j.Slf4j;
3839
import net.devh.boot.grpc.client.channelfactory.GrpcChannelConfigurer;
3940
import net.devh.boot.grpc.client.channelfactory.GrpcChannelFactory;
4041
import net.devh.boot.grpc.client.channelfactory.InProcessChannelFactory;
@@ -55,8 +56,8 @@
5556
* The auto configuration used by Spring-Boot that contains all beans to create and inject grpc clients into beans.
5657
*
5758
* @author Michael ([email protected])
58-
* @since 5/17/16
5959
*/
60+
@Slf4j
6061
@Configuration(proxyBeanMethods = false)
6162
@EnableConfigurationProperties
6263
@AutoConfigureAfter(name = "org.springframework.cloud.client.CommonsClientAutoConfiguration",
@@ -112,7 +113,7 @@ AnnotationGlobalClientInterceptorConfigurer annotationGlobalClientInterceptorCon
112113
@Bean
113114
NameResolverRegistration grpcNameResolverRegistration(
114115
@Autowired(required = false) final List<NameResolverProvider> nameResolverProviders) {
115-
NameResolverRegistration nameResolverRegistration = new NameResolverRegistration(nameResolverProviders);
116+
final NameResolverRegistration nameResolverRegistration = new NameResolverRegistration(nameResolverProviders);
116117
nameResolverRegistration.register(NameResolverRegistry.getDefaultRegistry());
117118
return nameResolverRegistration;
118119
}
@@ -141,9 +142,12 @@ List<GrpcChannelConfigurer> defaultChannelConfigurers() {
141142
"io.grpc.netty.shaded.io.grpc.netty.NettyChannelBuilder"})
142143
@Bean
143144
@Lazy
144-
GrpcChannelFactory shadedNettyGrpcChannelFactory(final GrpcChannelsProperties properties,
145+
GrpcChannelFactory shadedNettyGrpcChannelFactory(
146+
final GrpcChannelsProperties properties,
145147
final GlobalClientInterceptorRegistry globalClientInterceptorRegistry,
146148
final List<GrpcChannelConfigurer> channelConfigurers) {
149+
150+
log.info("Detected grpc-netty-shaded: Creating ShadedNettyChannelFactory + InProcessChannelFactory");
147151
final ShadedNettyChannelFactory channelFactory =
148152
new ShadedNettyChannelFactory(properties, globalClientInterceptorRegistry, channelConfigurers);
149153
final InProcessChannelFactory inProcessChannelFactory =
@@ -156,9 +160,12 @@ GrpcChannelFactory shadedNettyGrpcChannelFactory(final GrpcChannelsProperties pr
156160
@ConditionalOnClass(name = {"io.netty.channel.Channel", "io.grpc.netty.NettyChannelBuilder"})
157161
@Bean
158162
@Lazy
159-
GrpcChannelFactory nettyGrpcChannelFactory(final GrpcChannelsProperties properties,
163+
GrpcChannelFactory nettyGrpcChannelFactory(
164+
final GrpcChannelsProperties properties,
160165
final GlobalClientInterceptorRegistry globalClientInterceptorRegistry,
161166
final List<GrpcChannelConfigurer> channelConfigurers) {
167+
168+
log.info("Detected grpc-netty: Creating NettyChannelFactory + InProcessChannelFactory");
162169
final NettyChannelFactory channelFactory =
163170
new NettyChannelFactory(properties, globalClientInterceptorRegistry, channelConfigurers);
164171
final InProcessChannelFactory inProcessChannelFactory =
@@ -170,9 +177,12 @@ GrpcChannelFactory nettyGrpcChannelFactory(final GrpcChannelsProperties properti
170177
@ConditionalOnMissingBean(GrpcChannelFactory.class)
171178
@Bean
172179
@Lazy
173-
GrpcChannelFactory inProcessGrpcChannelFactory(final GrpcChannelsProperties properties,
180+
GrpcChannelFactory inProcessGrpcChannelFactory(
181+
final GrpcChannelsProperties properties,
174182
final GlobalClientInterceptorRegistry globalClientInterceptorRegistry,
175183
final List<GrpcChannelConfigurer> channelConfigurers) {
184+
185+
log.warn("Could not find a GrpcChannelFactory on the classpath: Creating InProcessChannelFactory as fallback");
176186
return new InProcessChannelFactory(properties, globalClientInterceptorRegistry, channelConfigurers);
177187
}
178188

grpc-server-spring-boot-autoconfigure/src/main/java/net/devh/boot/grpc/server/autoconfigure/GrpcServerFactoryAutoConfiguration.java

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.springframework.context.annotation.Conditional;
2929
import org.springframework.context.annotation.Configuration;
3030

31+
import lombok.extern.slf4j.Slf4j;
3132
import net.devh.boot.grpc.server.condition.ConditionalOnInterprocessServer;
3233
import net.devh.boot.grpc.server.config.GrpcServerProperties;
3334
import net.devh.boot.grpc.server.serverfactory.GrpcServerConfigurer;
@@ -45,6 +46,7 @@
4546
*
4647
* @author Daniel Theuke ([email protected])
4748
*/
49+
@Slf4j
4850
@Configuration(proxyBeanMethods = false)
4951
@ConditionalOnMissingBean({GrpcServerFactory.class, GrpcServerLifecycle.class})
5052
@AutoConfigureAfter(GrpcServerAutoConfiguration.class)
@@ -63,8 +65,12 @@ public class GrpcServerFactoryAutoConfiguration {
6365
"io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder"})
6466
@Conditional(ConditionalOnInterprocessServer.class)
6567
@Bean
66-
public ShadedNettyGrpcServerFactory shadedNettyGrpcServerFactory(final GrpcServerProperties properties,
67-
final GrpcServiceDiscoverer serviceDiscoverer, final List<GrpcServerConfigurer> serverConfigurers) {
68+
public ShadedNettyGrpcServerFactory shadedNettyGrpcServerFactory(
69+
final GrpcServerProperties properties,
70+
final GrpcServiceDiscoverer serviceDiscoverer,
71+
final List<GrpcServerConfigurer> serverConfigurers) {
72+
73+
log.info("Detected grpc-netty-shaded: Creating ShadedNettyGrpcServerFactory");
6874
final ShadedNettyGrpcServerFactory factory = new ShadedNettyGrpcServerFactory(properties, serverConfigurers);
6975
for (final GrpcServiceDefinition service : serviceDiscoverer.findGrpcServices()) {
7076
factory.addService(service);
@@ -80,7 +86,7 @@ public ShadedNettyGrpcServerFactory shadedNettyGrpcServerFactory(final GrpcServe
8086
*/
8187
@ConditionalOnBean(ShadedNettyGrpcServerFactory.class)
8288
@Bean
83-
public GrpcServerLifecycle shadedNettyGrpcServerLifecycle(ShadedNettyGrpcServerFactory factory) {
89+
public GrpcServerLifecycle shadedNettyGrpcServerLifecycle(final ShadedNettyGrpcServerFactory factory) {
8490
return new GrpcServerLifecycle(factory);
8591
}
8692

@@ -97,8 +103,12 @@ public GrpcServerLifecycle shadedNettyGrpcServerLifecycle(ShadedNettyGrpcServerF
97103
@Conditional(ConditionalOnInterprocessServer.class)
98104
@ConditionalOnClass(name = {"io.netty.channel.Channel", "io.grpc.netty.NettyServerBuilder"})
99105
@Bean
100-
public NettyGrpcServerFactory nettyGrpcServerFactory(final GrpcServerProperties properties,
101-
final GrpcServiceDiscoverer serviceDiscoverer, final List<GrpcServerConfigurer> serverConfigurers) {
106+
public NettyGrpcServerFactory nettyGrpcServerFactory(
107+
final GrpcServerProperties properties,
108+
final GrpcServiceDiscoverer serviceDiscoverer,
109+
final List<GrpcServerConfigurer> serverConfigurers) {
110+
111+
log.info("Detected grpc-netty: Creating NettyGrpcServerFactory");
102112
final NettyGrpcServerFactory factory = new NettyGrpcServerFactory(properties, serverConfigurers);
103113
for (final GrpcServiceDefinition service : serviceDiscoverer.findGrpcServices()) {
104114
factory.addService(service);
@@ -127,8 +137,11 @@ public GrpcServerLifecycle nettyGrpcServerLifecycle(final NettyGrpcServerFactory
127137
*/
128138
@ConditionalOnProperty(prefix = "grpc.server", name = "in-process-name")
129139
@Bean
130-
public InProcessGrpcServerFactory inProcessGrpcServerFactory(final GrpcServerProperties properties,
140+
public InProcessGrpcServerFactory inProcessGrpcServerFactory(
141+
final GrpcServerProperties properties,
131142
final GrpcServiceDiscoverer serviceDiscoverer) {
143+
144+
log.info("'grpc.server.in-process-name' is set: Creating InProcessGrpcServerFactory");
132145
final InProcessGrpcServerFactory factory = new InProcessGrpcServerFactory(properties);
133146
for (final GrpcServiceDefinition service : serviceDiscoverer.findGrpcServices()) {
134147
factory.addService(service);

0 commit comments

Comments
 (0)