Skip to content

Fix setting maxInboundMetadataSize from GLOBAL #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix setting maxInboundMetadataSize from GLOBAL #1093

merged 2 commits into from
Apr 19, 2024

Conversation

o-shevchenko
Copy link
Contributor

@o-shevchenko o-shevchenko commented Apr 19, 2024 •
edited
Loading

maxInboundMetadataSize works as expected after #1064 if you set it for the needed channel.
But it was missed for GLOBAL in copyDefaultsFrom method

grpc:
  client:
    GLOBAL:
      max-inbound-metadata-size: 16384 # value here is not copied to other services
    service:
      address: service:6565
      max-inbound-metadata-size: 16384 # you have to specify value for service even it's already present for  GLOBAL
      ```

@ST-DDT ST-DDT requested a review from yidongnan April 19, 2024 10:03
@yidongnan yidongnan merged commit cbbef18 into grpc-ecosystem:master Apr 19, 2024
@yidongnan yidongnan added this to the 3.2.0 milestone Apr 19, 2024
@o-shevchenko o-shevchenko deleted the maxInboundMetadataSize_global branch April 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@yidongnan yidongnan yidongnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@o-shevchenko @ST-DDT @yidongnan