[minor] Make map functions inline

Author: dchakarwarti

bazel-bin

@@ -0,0 +1 @@
+/usr/local/google/home/dchakarwarti/.cache/bazel/_bazel_dchakarwarti/2bbf26c7866faddfb80004c79cb2f937/execroot/proto_processing_lib/bazel-out/k8-fastbuild/bin

bazel-out

@@ -0,0 +1 @@
+/usr/local/google/home/dchakarwarti/.cache/bazel/_bazel_dchakarwarti/2bbf26c7866faddfb80004c79cb2f937/execroot/proto_processing_lib/bazel-out

bazel-proto_processing_lib

@@ -0,0 +1 @@
+/usr/local/google/home/dchakarwarti/.cache/bazel/_bazel_dchakarwarti/2bbf26c7866faddfb80004c79cb2f937/execroot/proto_processing_lib

bazel-testlogs

@@ -0,0 +1 @@
+/usr/local/google/home/dchakarwarti/.cache/bazel/_bazel_dchakarwarti/2bbf26c7866faddfb80004c79cb2f937/execroot/proto_processing_lib/bazel-out/k8-fastbuild/testlogs

proto_processing_lib/proto_scrubber/cloud_audit_log_field_checker.cc

@@ -32,16 +32,6 @@ namespace {
 // Returns pointer to message type name, or nullptr if field isn't a message or
 // has an unknown type. Caller does not own returned pointer.
 const std::string* GetMessageTypeName(const FieldMaskNode* node);
-
-const FieldMaskNode* FindPtrOrNull(
-    absl::flat_hash_map<std::string, const FieldMaskNode*> type_to_node,
-    const std::string& type_name) {
-  const auto& it = type_to_node.find(type_name);
-  if (it == type_to_node.end()) {
-    return nullptr;
-  }
-  return it->second;
-}
 }  // namespace
 
 CloudAuditLogFieldChecker::CloudAuditLogFieldChecker(
@@ -78,7 +68,9 @@ FieldCheckResults CloudAuditLogFieldChecker::CheckField(
     const std::string* type_name = GetMessageTypeName(current_node);
 
     if (type_name != nullptr) {
-      const FieldMaskNode* found_node = FindPtrOrNull(type_to_node, *type_name);
+      const auto& it = type_to_node.find(*type_name);
+      const FieldMaskNode* found_node =
+          it != type_to_node.end() ? it->second : nullptr;
       if (found_node == nullptr) {
         // Keep track of this message type in case it's cyclic.
         type_to_node.emplace(*type_name, current_node);

proto_processing_lib/proto_scrubber/field_mask_node.cc

@@ -28,41 +28,15 @@
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_join.h"
 #include "absl/strings/string_view.h"
-#include "src/google/protobuf/util/converter/utility.h"
+#include "ocpdiag/core/compat/status_macros.h"
 #include "proto_processing_lib/proto_scrubber/constants.h"
 #include "proto_processing_lib/proto_scrubber/utility.h"
-#include "ocpdiag/core/compat/status_macros.h"
+#include "src/google/protobuf/util/converter/utility.h"
 
 namespace proto_processing_lib::proto_scrubber {
 
-
-namespace {
-
 using google::protobuf::util::converter::ToSnakeCase;
 
-void InsertIfNotPresent(
-    absl::flat_hash_map<absl::string_view, const google::protobuf::Field*>&
-        child_name_child_map,
-    absl::string_view field_name, const google::protobuf::Field* field) {
-  if (!child_name_child_map.contains(field_name)) {
-    child_name_child_map.emplace(field_name, field);
-  }
-}
-
-const google::protobuf::Field* FindWithDefault(
-    absl::flat_hash_map<absl::string_view, const google::protobuf::Field*>&
-        child_name_child_map,
-    absl::string_view field_name) {
-  const auto& it = child_name_child_map.find(field_name);
-  if (it == child_name_child_map.end()) {
-    google::protobuf::Field* field = nullptr;
-    return field;
-  }
-  return it->second;
-}
-
-}  // namespace
-
 FieldMaskNode::FieldMaskNode(
     const google::protobuf::Type* type, bool is_leaf, bool is_map,
     bool all_keys_included,
@@ -106,23 +80,24 @@ const google::protobuf::Field* FieldMaskNode::FindChildField(
   // method is called).
   if (child_name_child_map_.empty()) {
     for (const google::protobuf::Field& field : type_->fields()) {
-      InsertIfNotPresent(&child_name_child_map_, field.name(), &field);
+      child_name_child_map_.try_emplace(field.name(), &field);
     }
-      if (type_->name() == kStructType || type_->name() == kStructValueType ||
-          type_->name() == kStructListValueType) {
-        // Add Struct type fields and List type fields for nested searching.
-        // A Struct value can be List. A List value can be Struct.
-        for (const google::protobuf::Field& field :
-             type_finder_(kStructTypeUrl)->fields()) {
-          InsertIfNotPresent(&child_name_child_map_, field.name(), &field);
-        }
-        for (const google::protobuf::Field& field :
-             type_finder_(kStructListValueTypeUrl)->fields()) {
-          InsertIfNotPresent(&child_name_child_map_, field.name(), &field);
-        }
+    if (type_->name() == kStructType || type_->name() == kStructValueType ||
+        type_->name() == kStructListValueType) {
+      // Add Struct type fields and List type fields for nested searching.
+      // A Struct value can be List. A List value can be Struct.
+      for (const google::protobuf::Field& field :
+           type_finder_(kStructTypeUrl)->fields()) {
+        child_name_child_map_.try_emplace(field.name(), &field);
       }
+      for (const google::protobuf::Field& field :
+           type_finder_(kStructListValueTypeUrl)->fields()) {
+        child_name_child_map_.try_emplace(field.name(), &field);
+      }
+    }
   }
-  return FindWithDefault(child_name_child_map_, field_name);
+  const auto& it = child_name_child_map_.find(field_name);
+  return it != child_name_child_map_.end() ? it->second : nullptr;
 }
 
 absl::Status FieldMaskNode::ParseFieldNameAndMapKey(const std::string& segment,