Update dependencies and fix warnings (#899)

Author: JamesNK

build/dependencies.props

@@ -1,23 +1,23 @@
 <Project>
   <PropertyGroup>
-    <BenchmarkDotNetPackageVersion>0.11.3</BenchmarkDotNetPackageVersion>
+    <BenchmarkDotNetPackageVersion>0.12.1</BenchmarkDotNetPackageVersion>
     <GoogleProtobufPackageVersion>3.11.4</GoogleProtobufPackageVersion>
     <GrpcDotNetPackageVersion>2.28.0-pre2</GrpcDotNetPackageVersion>  <!-- Only use for example projects -->
-    <GrpcPackageVersion>2.27.0</GrpcPackageVersion>
+    <GrpcPackageVersion>2.28.0</GrpcPackageVersion>
     <MicrosoftAspNetCorePackageVersion>3.1.3</MicrosoftAspNetCorePackageVersion>
-    <MicrosoftAspNetCoreBlazorPackageVersion>3.2.0-preview5.20216.8</MicrosoftAspNetCoreBlazorPackageVersion>
+    <MicrosoftAspNetCoreBlazorPackageVersion>3.2.0-rc1.20223.4</MicrosoftAspNetCoreBlazorPackageVersion>
     <MicrosoftBuildLocatorPackageVersion>1.2.2</MicrosoftBuildLocatorPackageVersion>
     <MicrosoftBuildPackageVersion>16.0.461</MicrosoftBuildPackageVersion>
-    <MicrosoftCodeAnalysisFxCopAnalyzersPackageVersion>2.9.4</MicrosoftCodeAnalysisFxCopAnalyzersPackageVersion>
+    <MicrosoftCodeAnalysisFxCopAnalyzersPackageVersion>3.0.0</MicrosoftCodeAnalysisFxCopAnalyzersPackageVersion>
     <MicrosoftExtensionsPackageVersion>2.1.1</MicrosoftExtensionsPackageVersion>
     <MicrosoftExtensions30PackageVersion>3.0.0</MicrosoftExtensions30PackageVersion>
-    <MicrosoftNETTestSdkPackageVersion>16.2.0</MicrosoftNETTestSdkPackageVersion>
-    <MicrosoftSourceLinkGitHubPackageVersion>1.0.0-beta2-19367-01</MicrosoftSourceLinkGitHubPackageVersion>
+    <MicrosoftNETTestSdkPackageVersion>16.6.1</MicrosoftNETTestSdkPackageVersion>
+    <MicrosoftSourceLinkGitHubPackageVersion>1.0.0</MicrosoftSourceLinkGitHubPackageVersion>
     <MicrosoftWin32RegistryLinePackageVersion>4.6.0</MicrosoftWin32RegistryLinePackageVersion>
     <MoqPackageVersion>4.10.0</MoqPackageVersion>
     <NewtonsoftJsonPackageVersion>12.0.2</NewtonsoftJsonPackageVersion>
     <NunitPackageVersion>3.12.0</NunitPackageVersion>
-    <Nunit3TestAdapterPackageVersion>3.13.0</Nunit3TestAdapterPackageVersion>
+    <Nunit3TestAdapterPackageVersion>3.16.1</Nunit3TestAdapterPackageVersion>
     <OpenTelemetryPackageVersion>0.2.0-alpha.100</OpenTelemetryPackageVersion>
     <SystemCommandLinePackageVersion>2.0.0-beta1.20214.1</SystemCommandLinePackageVersion>
     <SystemCommandLineRenderingPackageVersion>0.3.0-alpha.20214.1</SystemCommandLineRenderingPackageVersion>

perf/Grpc.AspNetCore.Microbenchmarks/DefaultCoreConfig.cs

@@ -25,7 +25,6 @@
 using BenchmarkDotNet.Loggers;
 using BenchmarkDotNet.Toolchains.CsProj;
 using BenchmarkDotNet.Toolchains.DotNetCli;
-using BenchmarkDotNet.Toolchains.InProcess;
 using BenchmarkDotNet.Validators;
 
 namespace Grpc.AspNetCore.Microbenchmarks
@@ -34,19 +33,19 @@ internal class DefaultCoreConfig : ManualConfig
     {
         public DefaultCoreConfig()
         {
-            Add(ConsoleLogger.Default);
-            Add(MarkdownExporter.GitHub);
+            AddLogger(ConsoleLogger.Default);
+            AddExporter(MarkdownExporter.GitHub);
 
-            Add(MemoryDiagnoser.Default);
-            Add(StatisticColumn.OperationsPerSecond);
-            Add(DefaultColumnProviders.Instance);
+            AddDiagnoser(MemoryDiagnoser.Default);
+            AddColumn(StatisticColumn.OperationsPerSecond);
+            AddColumnProvider(DefaultColumnProviders.Instance);
 
-            Add(JitOptimizationsValidator.FailOnError);
+            AddValidator(JitOptimizationsValidator.FailOnError);
 
-            Add(Job.Core
-                .With(CsProjCoreToolchain.From(new NetCoreAppSettings("netcoreapp3.1", null, ".NET Core 3.1")))
-                .With(new GcMode { Server = true })
-                .With(RunStrategy.Throughput));
+            AddJob(Job.Default
+                .WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings("netcoreapp3.1", null, ".NET Core 3.1")))
+                .WithGcMode(new GcMode { Server = true })
+                .WithStrategy(RunStrategy.Throughput));
         }
     }
 }

src/Grpc.Net.Client.Web/Internal/Base64RequestStream.cs

@@ -87,7 +87,7 @@ public override async ValueTask WriteAsync(ReadOnlyMemory<byte> data, Cancellati
                     OperationStatus.NeedMoreData);
 
                 var base64Remainder = _buffer.Length - localBuffer.Length;
-                await _inner.WriteAsync(_buffer.AsMemory(0, bytesWritten + base64Remainder), cancellationToken);
+                await _inner.WriteAsync(_buffer.AsMemory(0, bytesWritten + base64Remainder), cancellationToken).ConfigureAwait(false);
 
                 data = data.Slice(bytesConsumed);
                 localBuffer = _buffer;
@@ -97,7 +97,7 @@ public override async ValueTask WriteAsync(ReadOnlyMemory<byte> data, Cancellati
             // If there was not enough data to write along with remainder then write it here
             if (localBuffer.Length < _buffer.Length)
             {
-                await _inner.WriteAsync(_buffer.AsMemory(0, 4), cancellationToken);
+                await _inner.WriteAsync(_buffer.AsMemory(0, 4), cancellationToken).ConfigureAwait(false);
             }
 
             if (data.Length > 0)
@@ -180,7 +180,7 @@ public override void SetLength(long value)
         public override void Write(byte[] buffer, int offset, int count)
         {
             // Used by unit tests
-            WriteAsync(buffer.AsMemory(0, count)).GetAwaiter().GetResult();
+            WriteAsync(buffer.AsMemory(0, count)).AsTask().GetAwaiter().GetResult();
             FlushAsync().GetAwaiter().GetResult();
         }
         #endregion

src/Grpc.Net.Client.Web/Internal/Base64ResponseStream.cs

@@ -73,7 +73,7 @@ public override async ValueTask<int> ReadAsync(Memory<byte> data, CancellationTo
             // Minimum valid base64 length is 4. Read until we have at least that much content
             do
             {
-                var read = await _inner.ReadAsync(availableReadData, cancellationToken);
+                var read = await _inner.ReadAsync(availableReadData, cancellationToken).ConfigureAwait(false);
                 if (read == 0)
                 {
                     if (_remainder > 0)

src/Grpc.Net.Client.Web/Internal/GrpcWebResponseStream.cs

@@ -95,7 +95,7 @@ public override async ValueTask<int> ReadAsync(Memory<byte> data, CancellationTo
                         data = data.Slice(0, _contentRemaining);
                     }
 
-                    var read = await _inner.ReadAsync(data, cancellationToken);
+                    var read = await _inner.ReadAsync(data, cancellationToken).ConfigureAwait(false);
                     _contentRemaining -= read;
                     if (_contentRemaining == 0)
                     {
@@ -137,7 +137,7 @@ private async Task ReadTrailersAsync(int trailerLength, Memory<byte> data, Cance
             // 2. The response stream is read to completion. HttpClient may not recognize the
             //    request as completing successfully if the request and response aren't completely
             //    consumed.
-            var count = await _inner.ReadAsync(data, cancellationToken);
+            var count = await _inner.ReadAsync(data, cancellationToken).ConfigureAwait(false);
             if (count > 0)
             {
                 throw new InvalidOperationException("Unexpected data after trailers.");

src/Grpc.Net.Client/Internal/GrpcCall.cs

@@ -440,7 +440,7 @@ internal RpcException CreateRpcException(Status status)
             return new RpcException(status, trailers ?? Metadata.Empty);
         }
 
-        private async ValueTask RunCall(HttpRequestMessage request, TimeSpan? timeout)
+        private async Task RunCall(HttpRequestMessage request, TimeSpan? timeout)
         {
             using (StartScope())
             {