Dispose socket after connection failure (#2287)

JamesNK · web-flow · commit 207e8066f3ed · 2023-10-03T09:09:49.000+08:00
diff --git a/src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs b/src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
@@ -190,6 +190,9 @@ public async ValueTask<ConnectResult> TryConnectAsync(ConnectContext context)
             }
             catch (Exception ex)
             {
+                // Socket is recreated every connect attempt. Explicitly dispose failed socket before next attempt.
+                socket.Dispose();
+
                 SocketConnectivitySubchannelTransportLog.ErrorConnectingSocket(_logger, _subchannel.Id, currentEndPoint, ex);
 
                 if (firstConnectionError == null)

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,9 @@ public async ValueTask<ConnectResult> TryConnectAsync(ConnectContext context)`
`190`	`190`	`}`
`191`	`191`	`catch (Exception ex)`
`192`	`192`	`{`
	`193`	`+ // Socket is recreated every connect attempt. Explicitly dispose failed socket before next attempt.`
	`194`	`+ socket.Dispose();`
	`195`	`+`
`193`	`196`	`SocketConnectivitySubchannelTransportLog.ErrorConnectingSocket(_logger, _subchannel.Id, currentEndPoint, ex);`
`194`	`197`
`195`	`198`	`if (firstConnectionError == null)`