Fix issues related to VS and update SDK (#411)

Author: JamesNK

Directory.Build.props

@@ -16,16 +16,4 @@
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
-  <ItemGroup>
-    <!-- TODO (johluo): Remove this workaround when VS updates -->
-    <PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="$(MicrosoftNetCompilersToolsetPackageVersion)" PrivateAssets="All" />
-  </ItemGroup>
-
-  <Target Name="WorkaroundNetStandard" AfterTargets="ResolvePackageAssets">
-    <!-- TODO (jamesnk): Remove this workaround when VS updates - https://github.com/dotnet/cli/issues/11378#issuecomment-499988244 -->
-    <ItemGroup>
-      <TransitiveFrameworkReference Remove="NETStandard.Library" />
-    </ItemGroup>
-  </Target>
-
 </Project>

examples/Server/MailQueue.cs

@@ -43,7 +43,7 @@ public class MailQueue
         private int _forwardedMailCount;
 
         public string Name { get; }
-        public event Func<(int totalCount, int newCount, MailboxMessage.Types.Reason reason), Task> Changed;
+        public event Func<(int totalCount, int newCount, MailboxMessage.Types.Reason reason), Task>? Changed;
 
         public MailQueue(string name)
         {

global.json

@@ -1,5 +1,5 @@
 {
   "sdk": {
-    "version": "3.0.100-preview8-013248"
+    "version": "3.0.100-preview8-013421"
   }
 }

perf/Grpc.AspNetCore.Microbenchmarks/Internal/TestPipeReader.cs

@@ -51,6 +51,7 @@ public override void Complete(Exception? exception = null)
             throw new NotImplementedException();
         }
 
+        [Obsolete]
         public override void OnWriterCompleted(Action<Exception, object> callback, object state)
         {
             throw new NotImplementedException();

perf/Grpc.AspNetCore.Microbenchmarks/Internal/TestPipeWriter.cs

@@ -44,6 +44,7 @@ public override Span<byte> GetSpan(int sizeHint = 0)
             return _buffer;
         }
 
+        [Obsolete]
         public override void OnReaderCompleted(Action<Exception, object> callback, object state)
         {
             throw new NotImplementedException();

src/Grpc.AspNetCore.Server/Internal/GrpcProtocolHelpers.cs

@@ -18,13 +18,10 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
-using System.IO;
-using System.IO.Compression;
-using System.Runtime.CompilerServices;
 using System.Security.Cryptography.X509Certificates;
 using System.Text;
-using Grpc.AspNetCore.Server.Compression;
 using Grpc.Core;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Features;

src/Grpc.AspNetCore.Server/Internal/NotNullWhenAttribute.cs

@@ -21,11 +21,11 @@
 using System.Buffers.Binary;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.IO.Compression;
 using System.IO.Pipelines;
 using System.Linq;
-using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Grpc.AspNetCore.Server.Compression;

src/Grpc.AspNetCore.Server/Internal/PipeExtensions.cs

@@ -30,7 +30,7 @@ public class LogSinkProvider : ILoggerProvider, ISupportExternalScope
 
         private IExternalScopeProvider? _scopeProvider;
 
-        public event Action<LogRecord> RecordLogged;
+        public event Action<LogRecord>? RecordLogged;
 
         public ILogger CreateLogger(string categoryName)
         {