Skip to content

Commit 520c574

Browse files
authored
Change Resolver.ResolveAsync to virtual (#1523)
1 parent d5626ab commit 520c574

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

src/Grpc.Net.Client/Balancer/Resolver.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,10 @@ private async Task ResolveNowAsync(CancellationToken cancellationToken)
173173
/// </summary>
174174
/// <param name="cancellationToken">A cancellation token.</param>
175175
/// <returns>A task.</returns>
176-
protected abstract Task ResolveAsync(CancellationToken cancellationToken);
176+
protected virtual Task ResolveAsync(CancellationToken cancellationToken)
177+
{
178+
return Task.CompletedTask;
179+
}
177180

178181
/// <summary>
179182
/// Releases the unmanaged resources used by the <see cref="LoadBalancer"/> and optionally releases

src/Grpc.Net.Client/Balancer/StaticResolver.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,6 @@ protected override void OnStarted()
5353
// Send addresses to listener once. They will never change.
5454
Listener(ResolverResult.ForResult(_addresses, serviceConfig: null, serviceConfigStatus: null));
5555
}
56-
57-
/// <inheritdoc />
58-
protected override Task ResolveAsync(CancellationToken cancellationToken)
59-
{
60-
return Task.CompletedTask;
61-
}
6256
}
6357

6458
/// <summary>

test/Grpc.Net.Client.Tests/GrpcChannelTests.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -836,11 +836,6 @@ public ChannelTestResolver(ResolverOptions options) : base(options.LoggerFactory
836836
}
837837

838838
public ResolverOptions Options { get; }
839-
840-
protected override Task ResolveAsync(CancellationToken cancellationToken)
841-
{
842-
throw new NotImplementedException();
843-
}
844839
}
845840
#endif
846841

0 commit comments

Comments
 (0)