Minor improvements in examples codebase: Mailer (#1312)

Co-authored-by: James Newton-King <[email protected]>

Author: kiapanahi

examples/Mailer/Client/Program.cs

@@ -75,7 +75,7 @@ static async Task Main(string[] args)
 
         private static string GetMailboxName(string[] args)
         {
-            if (args.Length != 1)
+            if (args.Length < 1)
             {
                 Console.WriteLine("No mailbox name provided. Using default name. Usage: dotnet run <name>.");
                 return "DefaultMailbox";

examples/Mailer/Server/MailQueue.cs

@@ -25,17 +25,9 @@
 
 namespace Server
 {
-    public class Mail
-    {
-        public Mail(int id, string content)
-        {
-            Id = id;
-            Content = content;
-        }
+    public record Mail(int Id, string Content);
 
-        public int Id { get; }
-        public string Content { get; }
-    }
+    public record MailQueueChangeState(int TotalCount, int ForwardedCount, MailboxMessage.Types.Reason Reason);
 
     public class MailQueue
     {
@@ -44,15 +36,15 @@ public class MailQueue
         private int _forwardedMailCount;
 
         public string Name { get; }
-        public event Func<(int totalCount, int newCount, MailboxMessage.Types.Reason reason), Task>? Changed;
+        public event Func<MailQueueChangeState, Task>? Changed;
 
         public MailQueue(string name)
         {
             Name = name;
 
             _incomingMail = Channel.CreateUnbounded<Mail>();
 
-            Task.Run(async () =>
+            _ = Task.Run(async () =>
             {
                 var random = new Random();
 
@@ -83,7 +75,7 @@ public bool TryForwardMail([NotNullWhen(true)] out Mail? message)
 
         private void OnChange(MailboxMessage.Types.Reason reason)
         {
-            Changed?.Invoke((_totalMailCount, _forwardedMailCount, reason));
+            Changed?.Invoke(new MailQueueChangeState(_totalMailCount, _forwardedMailCount, reason));
         }
     }
 }

examples/Mailer/Server/MailQueueRepository.cs

@@ -22,7 +22,7 @@ namespace Server
 {
     public class MailQueueRepository
     {
-        private ConcurrentDictionary<string, MailQueue> _mailQueues = new ConcurrentDictionary<string, MailQueue>();
+        private readonly ConcurrentDictionary<string, MailQueue> _mailQueues = new();
 
         public MailQueue GetMailQueue(string name)
         {

examples/Mailer/Server/Services/MailerService.cs

@@ -69,13 +69,13 @@ public async override Task Mailbox(
 
             _logger.LogInformation($"{mailboxName} disconnected");
 
-            async Task ReportChanges((int totalCount, int fowardCount, MailboxMessage.Types.Reason reason) state)
+            async Task ReportChanges(MailQueueChangeState state)
             {
                 await responseStream.WriteAsync(new MailboxMessage
                 {
-                    Forwarded = state.fowardCount,
-                    New = state.totalCount - state.fowardCount,
-                    Reason = state.reason
+                    Forwarded = state.ForwardedCount,
+                    New = state.TotalCount - state.ForwardedCount,
+                    Reason = state.Reason
                 });
             }
         }