Skip to content

Commit 637afdb

Browse files
authored
Don't include server header in benchmarks for real this time (#1055)
1 parent 59062ec commit 637afdb

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

perf/benchmarkapps/GrpcAspNetCoreServer/Program.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ public static IHostBuilder CreateHostBuilder(string[] args)
8888
ConfigureListenOptions(listenOptions, config, endPoint);
8989
});
9090
}
91+
92+
// Other gRPC servers don't include a server header
93+
options.AddServerHeader = false;
9194
});
9295
})
9396
.ConfigureLogging(loggerFactory =>

testassets/InteropTestsWebsite/Program.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public static IHostBuilder CreateHostBuilder(string[] args) =>
5353
var http1Port = context.Configuration.GetValue<int>("port_http1", -1);
5454
var useTls = context.Configuration.GetValue<bool>("use_tls", false);
5555

56-
options.AddServerHeader = false;
5756
options.Limits.MinRequestBodyDataRate = null;
5857
options.ListenAnyIP(http2Port, o => ConfigureEndpoint(o, useTls, HttpProtocols.Http2));
5958
if (http1Port != -1)

0 commit comments

Comments
 (0)