Correctness: Make some private & internal classes sealed where possible (#2559)

Author: Henr1k80

perf/benchmarkapps/Shared/BenchmarkServiceImpl.cs

@@ -20,7 +20,7 @@
 using Grpc.Core;
 using Grpc.Testing;
 
-class BenchmarkServiceImpl : BenchmarkService.BenchmarkServiceBase
+sealed class BenchmarkServiceImpl : BenchmarkService.BenchmarkServiceBase
 {
 #if CLIENT_CERTIFICATE_AUTHENTICATION
     [Microsoft.AspNetCore.Authorization.Authorize]
@@ -98,4 +98,4 @@ public static SimpleResponse CreateResponse(SimpleRequest request)
         var payload = new Payload { Body = body };
         return new SimpleResponse { Payload = payload };
     }
-}
+}

src/Grpc.AspNetCore.Server/Internal/CallHandlers/ClientStreamingServerCallHandler.cs

@@ -24,7 +24,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal.CallHandlers;
 
-internal class ClientStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
+internal sealed class ClientStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
     where TRequest : class
     where TResponse : class
     where TService : class

src/Grpc.AspNetCore.Server/Internal/CallHandlers/DuplexStreamingServerCallHandler.cs

@@ -23,7 +23,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal.CallHandlers;
 
-internal class DuplexStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
+internal sealed class DuplexStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
     where TRequest : class
     where TResponse : class
     where TService : class

src/Grpc.AspNetCore.Server/Internal/CallHandlers/ServerStreamingServerCallHandler.cs

@@ -23,7 +23,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal.CallHandlers;
 
-internal class ServerStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
+internal sealed class ServerStreamingServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
     where TRequest : class
     where TResponse : class
     where TService : class

src/Grpc.AspNetCore.Server/Internal/CallHandlers/UnaryServerCallHandler.cs

@@ -24,7 +24,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal.CallHandlers;
 
-internal class UnaryServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
+internal sealed class UnaryServerCallHandler<[DynamicallyAccessedMembers(GrpcProtocolConstants.ServiceAccessibility)] TService, TRequest, TResponse> : ServerCallHandlerBase<TService, TRequest, TResponse>
     where TRequest : class
     where TResponse : class
     where TService : class

src/Grpc.AspNetCore.Server/Internal/GrpcMarkerService.cs

@@ -24,6 +24,6 @@ namespace Grpc.AspNetCore.Server.Internal;
 /// A marker class used to determine if all the required gRPC services were added
 /// to the <see cref="IServiceCollection"/>.
 /// </summary>
-internal class GrpcMarkerService
+internal sealed class GrpcMarkerService
 {
 }

src/Grpc.AspNetCore.Server/Internal/GrpcServerBuilder.cs

@@ -20,7 +20,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal;
 
-internal class GrpcServerBuilder : IGrpcServerBuilder
+internal sealed class GrpcServerBuilder : IGrpcServerBuilder
 {
     public IServiceCollection Services { get; }
 

src/Grpc.AspNetCore.Server/Internal/GrpcServiceOptionsSetup.cs

@@ -22,7 +22,7 @@
 
 namespace Grpc.AspNetCore.Server.Internal;
 
-internal class GrpcServiceOptionsSetup : IConfigureOptions<GrpcServiceOptions>
+internal sealed class GrpcServiceOptionsSetup : IConfigureOptions<GrpcServiceOptions>
 {
     // Default to no send limit and 4mb receive limit.
     // Matches the gRPC C impl defaults
@@ -45,7 +45,7 @@ public void Configure(GrpcServiceOptions options)
     }
 }
 
-internal class GrpcServiceOptionsSetup<TService> : IConfigureOptions<GrpcServiceOptions<TService>> where TService : class
+internal sealed class GrpcServiceOptionsSetup<TService> : IConfigureOptions<GrpcServiceOptions<TService>> where TService : class
 {
     private readonly GrpcServiceOptions _options;
 

src/Grpc.AspNetCore.Server/Internal/HttpContextStreamReader.cs

@@ -26,7 +26,7 @@ namespace Grpc.AspNetCore.Server.Internal;
 
 [DebuggerDisplay("{DebuggerToString(),nq}")]
 [DebuggerTypeProxy(typeof(HttpContextStreamReader<>.HttpContextStreamReaderDebugView))]
-internal class HttpContextStreamReader<TRequest> : IAsyncStreamReader<TRequest> where TRequest : class
+internal sealed class HttpContextStreamReader<TRequest> : IAsyncStreamReader<TRequest> where TRequest : class
 {
     private readonly HttpContextServerCallContext _serverCallContext;
     private readonly Func<DeserializationContext, TRequest> _deserializer;

src/Grpc.AspNetCore.Server/Internal/HttpContextStreamWriter.cs

@@ -26,7 +26,7 @@ namespace Grpc.AspNetCore.Server.Internal;
 
 [DebuggerDisplay("{DebuggerToString(),nq}")]
 [DebuggerTypeProxy(typeof(HttpContextStreamWriter<>.HttpContextStreamWriterDebugView))]
-internal class HttpContextStreamWriter<TResponse> : IServerStreamWriter<TResponse>
+internal sealed class HttpContextStreamWriter<TResponse> : IServerStreamWriter<TResponse>
     where TResponse : class
 {
     private readonly HttpContextServerCallContext _context;