Add readonly to record structs (#1584)

Author: JamesNK

src/Grpc.AspNetCore.Web/Grpc.AspNetCore.Web.csproj

@@ -18,6 +18,7 @@
     <None Include="README.md" Pack="true" PackagePath="\" />
 
     <Compile Include="..\Shared\CommonGrpcProtocolHelpers.cs" Link="Internal\CommonGrpcProtocolHelpers.cs" />
+    <Compile Include="..\Shared\IsExternalInit.cs" Link="Internal\IsExternalInit.cs" />
   </ItemGroup>
 
   <ItemGroup>

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs

@@ -113,24 +113,20 @@ private static string ResolveContentType(string newContentType, string originalC
 
         internal static ServerGrpcWebContext GetGrpcWebContext(HttpContext httpContext)
         {
-            var serverContext = new ServerGrpcWebContext();
-
-            if (TryGetWebMode(httpContext.Request.ContentType, out var requestMode))
+            if (!TryGetWebMode(httpContext.Request.ContentType, out var requestMode))
             {
-                serverContext.Request = requestMode;
-
-                if (TryGetWebMode(httpContext.Request.Headers["Accept"], out var responseMode))
-                {
-                    serverContext.Response = responseMode;
-                }
-                else
-                {
-                    // If there isn't a request 'accept' header then default to mode to 'application/grpc`.
-                    serverContext.Response = ServerGrpcWebMode.GrpcWeb;
-                }
+                return default;
             }
 
-            return serverContext;
+            if (TryGetWebMode(httpContext.Request.Headers["Accept"], out var responseMode))
+            {
+                return new ServerGrpcWebContext(requestMode, responseMode);
+            }
+            else
+            {
+                // If there isn't a request 'accept' header then default to mode to 'application/grpc`.
+                return new ServerGrpcWebContext(requestMode, ServerGrpcWebMode.GrpcWeb);
+            }
         }
 
         private static bool TryGetWebMode(string? contentType, out ServerGrpcWebMode mode)

src/Grpc.AspNetCore.Web/Internal/ServerGrpcWebMode.cs

@@ -18,7 +18,7 @@
 
 namespace Grpc.AspNetCore.Web.Internal
 {
-    internal record struct ServerGrpcWebContext(ServerGrpcWebMode Request, ServerGrpcWebMode Response);
+    internal readonly record struct ServerGrpcWebContext(ServerGrpcWebMode Request, ServerGrpcWebMode Response);
 
     internal enum ServerGrpcWebMode
     {

src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs

@@ -49,7 +49,7 @@ namespace Grpc.Net.Client.Balancer.Internal
     /// </summary>
     internal class SocketConnectivitySubchannelTransport : ISubchannelTransport, IDisposable
     {
-        internal record struct ActiveStream(BalancerAddress Address, Socket Socket, Stream? Stream);
+        internal readonly record struct ActiveStream(BalancerAddress Address, Socket Socket, Stream? Stream);
 
         private readonly ILogger _logger;
         private readonly Subchannel _subchannel;

src/Grpc.Net.ClientFactory/Grpc.Net.ClientFactory.csproj

@@ -13,6 +13,7 @@
   <ItemGroup>
     <None Include="README.md" Pack="true" PackagePath="\" />
 
+    <Compile Include="..\Shared\IsExternalInit.cs" Link="Internal\IsExternalInit.cs" />
     <Compile Include="..\Shared\HttpHandlerFactory.cs" Link="Internal\HttpHandlerFactory.cs" />
     <Compile Include="..\Shared\TelemetryHeaderHandler.cs" Link="Internal\TelemetryHeaderHandler.cs" />
     <Compile Include="..\Shared\CompatibilityHelpers.cs" Link="Internal\CompatibilityHelpers.cs" />

src/Grpc.Net.ClientFactory/Internal/GrpcCallInvokerFactory.cs

@@ -26,7 +26,7 @@
 
 namespace Grpc.Net.ClientFactory.Internal
 {
-    internal record struct EntryKey(string Name, Type Type);
+    internal readonly record struct EntryKey(string Name, Type Type);
 
     internal class GrpcCallInvokerFactory
     {

src/Shared/IsExternalInit.cs

@@ -0,0 +1,26 @@
+#region Copyright notice and license
+
+// Copyright 2019 The gRPC Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#endregion
+
+namespace System.Runtime.CompilerServices
+{
+#if NETCOREAPP3_0 || NETSTANDARD2_0_OR_GREATER
+    internal static class IsExternalInit
+    {
+    }
+#endif
+}