Code clean up across solution (#1530)

Author: JamesNK

examples/Racer/Server/Services/RacerService.cs

@@ -18,6 +18,7 @@
 
 using System;
 using System.Diagnostics;
+using System.Globalization;
 using System.Linq;
 using System.Threading.Tasks;
 using Grpc.Core;
@@ -29,7 +30,7 @@ public class RacerService : Racer.RacerBase
     {
         public override async Task ReadySetGo(IAsyncStreamReader<RaceMessage> requestStream, IServerStreamWriter<RaceMessage> responseStream, ServerCallContext context)
         {
-            var raceDuration = TimeSpan.Parse(context.RequestHeaders.Single(h => h.Key == "race-duration").Value);
+            var raceDuration = TimeSpan.Parse(context.RequestHeaders.GetValue("race-duration"), CultureInfo.InvariantCulture);
 
             // Read incoming messages in a background task
             RaceMessage? lastMessageReceived = null;

examples/Tester/Tests/UnitTests/Helpers/TestAsyncStreamReader.cs

@@ -54,7 +54,7 @@ public async Task<bool> MoveNext(CancellationToken cancellationToken)
         {
             _serverCallContext.CancellationToken.ThrowIfCancellationRequested();
 
-            if (await _channel.Reader.WaitToReadAsync() &&
+            if (await _channel.Reader.WaitToReadAsync(cancellationToken) &&
                 _channel.Reader.TryRead(out var message))
             {
                 Current = message;

examples/Worker/Client/Worker.cs

@@ -44,7 +44,8 @@ public Worker(ILogger<Worker> logger, Counter.CounterClient counterClient)
         public override async Task StartAsync(CancellationToken cancellationToken)
         {
             _logger.LogInformation("Starting client streaming call at: {time}", DateTimeOffset.Now);
-            _clientStreamingCall = _counterClient.AccumulateCount();
+            // Don't pass cancellation token to the call. The call is completed in StopAsync when service stops.
+            _clientStreamingCall = _counterClient.AccumulateCount(cancellationToken: CancellationToken.None);
 
             await base.StartAsync(cancellationToken);
         }

perf/Grpc.AspNetCore.Microbenchmarks/Client/UnaryClientBenchmarkBase.cs

@@ -77,7 +77,7 @@ protected virtual byte[] GetMessageData(HelloReply message)
         protected async Task InvokeSayHelloAsync(CallOptions options)
         {
             var response = await _client!.SayHelloAsync(new HelloRequest { Name = _content }, options).ResponseAsync;
-            
+
             if (response.Message != _content)
             {
                 throw new InvalidOperationException("Unexpected result.");

perf/Grpc.AspNetCore.Microbenchmarks/DefaultCoreConfigAttribute.cs

@@ -20,6 +20,7 @@
 
 namespace Grpc.AspNetCore.Microbenchmarks
 {
+    [AttributeUsage(AttributeTargets.Assembly)]
     public class DefaultCoreConfigAttribute : Attribute, IConfigSource
     {
         public IConfig Config => new DefaultCoreConfig();

perf/benchmarkapps/GrpcAspNetCoreServer/Controllers/BenchmarkController.cs

@@ -25,7 +25,7 @@ namespace GrpcAspNetCoreServer.Controllers
     public class BenchmarkController : Controller
     {
         [HttpPost("unary")]
-        public SimpleResponse Post([FromBody]SimpleRequest request)
+        public SimpleResponse Post([FromBody] SimpleRequest request)
         {
             return BenchmarkServiceImpl.CreateResponse(request);
         }

perf/benchmarkapps/GrpcAspNetCoreServer/Startup.cs

@@ -100,7 +100,7 @@ public void Configure(IApplicationBuilder app, IHostApplicationLifetime applicat
                 ConfigureAuthorization(endpoints.MapGrpcService<BenchmarkServiceImpl>());
 
                 ConfigureAuthorization(endpoints.MapControllers());
-                
+
                 ConfigureAuthorization(endpoints.MapGet("/", context =>
                 {
                     return context.Response.WriteAsync("Benchmark Server");

perf/benchmarkapps/GrpcClient/Program.cs

@@ -19,6 +19,7 @@
 using System.CommandLine;
 using System.CommandLine.Invocation;
 using System.Diagnostics;
+using System.Globalization;
 using System.Net.Security;
 using System.Net.Sockets;
 using System.Reflection;
@@ -43,17 +44,17 @@ class Program
         private static List<List<double>> _latencyPerConnection = null!;
         private static int _callsStarted;
         private static double _maxLatency;
-        private static Stopwatch _workTimer = new Stopwatch();
+        private static readonly Stopwatch _workTimer = new Stopwatch();
         private static volatile bool _warmingUp;
         private static volatile bool _stopped;
-        private static SemaphoreSlim _lock = new SemaphoreSlim(1);
+        private static readonly SemaphoreSlim _lock = new SemaphoreSlim(1);
         private static List<(double sum, int count)> _latencyAverage = null!;
         private static int _totalRequests;
         private static ClientOptions _options = null!;
         private static ILoggerFactory? _loggerFactory;
         private static SslCredentials? _credentials;
-        private static StringBuilder _errorStringBuilder = new StringBuilder();
-        private static CancellationTokenSource _cts = new CancellationTokenSource();
+        private static readonly StringBuilder _errorStringBuilder = new StringBuilder();
+        private static readonly CancellationTokenSource _cts = new CancellationTokenSource();
 
         public static async Task<int> Main(string[] args)
         {
@@ -170,7 +171,7 @@ private static async Task StartScenario()
                 var text = "Exception from test: " + ex.Message;
                 Log(text);
                 _errorStringBuilder.AppendLine();
-                _errorStringBuilder.Append($"[{DateTime.Now:hh:mm:ss.fff}] {text}");
+                _errorStringBuilder.Append(CultureInfo.InvariantCulture, $"[{DateTime.Now:hh:mm:ss.fff}] {text}");
             }
         }
 
@@ -463,7 +464,7 @@ private static SslCredentials GetSslCredentials()
 
         private static void Log(string message)
         {
-            var time = DateTime.Now.ToString("hh:mm:ss.fff");
+            var time = DateTime.Now.ToString("hh:mm:ss.fff", CultureInfo.InvariantCulture);
             Console.WriteLine($"[{time}] {message}");
         }
 

perf/benchmarkapps/Shared/BenchmarkServiceImpl.cs

@@ -16,9 +16,9 @@
 
 #endregion
 
-using Grpc.Testing;
-using Grpc.Core;
 using Google.Protobuf;
+using Grpc.Core;
+using Grpc.Testing;
 
 class BenchmarkServiceImpl : BenchmarkService.BenchmarkServiceBase
 {

src/Grpc.AspNetCore.Server.ClientFactory/ContextPropagationInterceptor.cs

@@ -172,7 +172,7 @@ private ClientInterceptorContext<TRequest, TResponse> ConfigureContext<TRequest,
             return new ClientInterceptorContext<TRequest, TResponse>(context.Method, context.Host, options);
         }
 
-        private bool TryGetServerCallContext([NotNullWhen(true)]out ServerCallContext? serverCallContext, [NotNullWhen(false)]out string? errorMessage)
+        private bool TryGetServerCallContext([NotNullWhen(true)] out ServerCallContext? serverCallContext, [NotNullWhen(false)] out string? errorMessage)
         {
             var httpContext = _httpContextAccessor.HttpContext;
             if (httpContext == null)