Skip to content

Commit 5228736

Browse files
authored
xds: Fix log level and message (#8608)
RELEASE NOTES: N/A
1 parent 8e6c228 commit 5228736

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

internal/xds/balancer/clusterimpl/clusterimpl.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,10 @@ func (b *clusterImplBalancer) NewSubConn(addrs []resolver.Address, opts balancer
451451
lID := xdsinternal.GetLocalityID(addr)
452452
if (lID == clients.Locality{}) {
453453
if b.logger.V(2) {
454-
b.logger.Infof("Locality ID for %s unexpectedly empty", addr)
454+
// TODO: After A74, we should have the entire CDS config,
455+
// allowing us to verify if this is indeed a Logical DNS cluster
456+
// and avoid logging the message below.
457+
b.logger.Infof("No Locality ID found for address %s. This is normal if %q is a Logical DNS cluster.", addr, clusterName)
455458
}
456459
return
457460
}

internal/xds/clients/xdsclient/ads_stream.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ func (s *adsStreamImpl) sendMessageLocked(stream clients.Stream, names []string,
458458
if s.logger.V(perRPCVerbosityLevel) {
459459
s.logger.Infof("ADS request sent: %v", pretty.ToJSON(req))
460460
} else if s.logger.V(2) {
461-
s.logger.Warningf("ADS request sent for type %q, resources: %v, version: %q, nonce: %q", url, names, version, nonce)
461+
s.logger.Infof("ADS request sent for type %q, resources: %v, version: %q, nonce: %q", url, names, version, nonce)
462462
}
463463

464464
return nil

0 commit comments

Comments
 (0)