Skip to content

Commit d947c80

Browse files
authored
interop-testing: make soak test use logger rather than writing to stderr directly
1 parent 6ffcbd9 commit d947c80

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

interop-testing/src/main/java/io/grpc/testing/integration/SoakClient.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import java.util.Locale;
4040
import java.util.concurrent.TimeUnit;
4141
import java.util.concurrent.atomic.AtomicReference;
42+
import java.util.logging.Logger;
4243
import org.HdrHistogram.Histogram;
4344

4445
/**
@@ -48,6 +49,8 @@
4849
* https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md#rpc_soak
4950
*/
5051
final class SoakClient {
52+
private static final Logger logger = Logger.getLogger(SoakClient.class.getName());
53+
5154
private static class SoakIterationResult {
5255
public SoakIterationResult(long latencyMs, Status status) {
5356
this.latencyMs = latencyMs;
@@ -171,7 +174,7 @@ public static void performSoakTest(
171174
iterationsDone += threadResult.getIterationsDone();
172175
latencies.add(threadResult.getLatencies());
173176
}
174-
System.err.println(
177+
logger.info(
175178
String.format(
176179
Locale.US,
177180
"(server_uri: %s) soak test ran: %d / %d iterations. total failures: %d. "
@@ -244,14 +247,16 @@ private static void executeSoakTestInThread(
244247
if (!result.getStatus().equals(Status.OK)) {
245248
threadResults.threadFailures++;
246249
logStr.append(String.format(" failed: %s", result.getStatus()));
250+
logger.warning(logStr.toString());
247251
} else if (result.getLatencyMs() > maxAcceptablePerIterationLatencyMs) {
248252
threadResults.threadFailures++;
249253
logStr.append(
250254
" exceeds max acceptable latency: " + maxAcceptablePerIterationLatencyMs);
255+
logger.warning(logStr.toString());
251256
} else {
252257
logStr.append(" succeeded");
258+
logger.info(logStr.toString());
253259
}
254-
System.err.println(logStr.toString());
255260
threadResults.iterationsDone++;
256261
threadResults.getLatencies().recordValue(result.getLatencyMs());
257262
long remainingNs = earliestNextStartNs - System.nanoTime();

0 commit comments

Comments
 (0)