Skip to content

Commit 163597e

Browse files
committed
Use command line arguments more consistently
1 parent 7c93431 commit 163597e

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

examples/metadata/client.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -242,15 +242,10 @@ const message = 'this is examples/metadata';
242242

243243
async function main() {
244244
let argv = parseArgs(process.argv.slice(2), {
245-
string: 'target'
245+
string: 'target',
246+
default: {target: 'localhost:50052'}
246247
});
247-
let target;
248-
if (argv.target) {
249-
target = argv.target;
250-
} else {
251-
target = 'localhost:50051';
252-
}
253-
const client = new echoProto.Echo(target, grpc.credentials.createInsecure());
248+
const client = new echoProto.Echo(argv.target, grpc.credentials.createInsecure());
254249
await unaryCallWithMetadata(client, message);
255250
await asyncWait(1000);
256251

examples/metadata/server.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,13 @@ const serviceImplementation = {
142142
};
143143

144144
function main() {
145+
const argv = parseArgs(process.argv.slice(2), {
146+
string: 'port',
147+
default: {port: '50052'}
148+
});
145149
const server = new grpc.Server();
146150
server.addService(echoProto.Echo.service, serviceImplementation);
147-
server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => {
151+
server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), () => {
148152
server.start();
149153
});
150154
}

0 commit comments

Comments
 (0)