Resolve exception when Error.stackTraceLimit is undefined

davidfiala · murgatroid99 · commit 213230c73b93 · 2024-04-01T15:05:25.000-07:00
Some applications may explicitly set Error.stackTraceLimit = undefined. In this case it is not safe to assume new Error().stack is available.
diff --git a/packages/grpc-js/src/client.ts b/packages/grpc-js/src/client.ts
@@ -110,7 +110,7 @@ export type ClientOptions = Partial<ChannelOptions> & {
 };
 
 function getErrorStackString(error: Error): string {
-  return error.stack!.split('\n').slice(1).join('\n');
+  return error.stack?.split('\n').slice(1).join('\n') || 'no stack trace available';
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ export type ClientOptions = Partial<ChannelOptions> & {`
`110`	`110`	`};`
`111`	`111`
`112`	`112`	`function getErrorStackString(error: Error): string {`
`113`		`- return error.stack!.split('\n').slice(1).join('\n');`
	`113`	`+ return error.stack?.split('\n').slice(1).join('\n') \|\| 'no stack trace available';`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`/**`