Skip to content

Commit 605f14a

Browse files
authored
Merge pull request #2814 from becoded/call-credential-generate-metadata-method-name
Provide the method_name for the CallCredentials callback generateMetadata
2 parents 21f4708 + 268d7eb commit 605f14a

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

packages/grpc-js/src/call-credentials.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import { Metadata } from './metadata';
1919

2020
export interface CallMetadataOptions {
21+
method_name: string;
2122
service_url: string;
2223
}
2324

packages/grpc-js/src/load-balancing-call.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export class LoadBalancingCall implements Call, DeadlineInfoProvider {
162162
switch (pickResult.pickResultType) {
163163
case PickResultType.COMPLETE:
164164
this.credentials
165-
.generateMetadata({ service_url: this.serviceUrl })
165+
.generateMetadata({ method_name: this.methodName, service_url: this.serviceUrl })
166166
.then(
167167
credsMetadata => {
168168
/* If this call was cancelled (e.g. by the deadline) before

packages/grpc-js/test/test-call-credentials.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ describe('CallCredentials', () => {
8787
generateFromServiceURL
8888
);
8989
const metadata: Metadata = await callCredentials.generateMetadata({
90+
method_name: 'bar',
9091
service_url: 'foo',
9192
});
9293

@@ -98,7 +99,7 @@ describe('CallCredentials', () => {
9899
CallCredentials.createFromMetadataGenerator(generateWithError);
99100
let metadata: Metadata | null = null;
100101
try {
101-
metadata = await callCredentials.generateMetadata({ service_url: '' });
102+
metadata = await callCredentials.generateMetadata({ method_name: '', service_url: '' });
102103
} catch (err) {
103104
assert.ok(err instanceof Error);
104105
}
@@ -139,6 +140,7 @@ describe('CallCredentials', () => {
139140
testCases.map(async testCase => {
140141
const { credentials, expected } = testCase;
141142
const metadata: Metadata = await credentials.generateMetadata({
143+
method_name: '',
142144
service_url: '',
143145
});
144146

0 commit comments

Comments
 (0)