Skip to content

Commit 6ba0081

Browse files
committed
only attempt to use custom compression filter when option value is provided
1 parent 25a1806 commit 6ba0081

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

packages/grpc-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
},
6060
"dependencies": {
6161
"@grpc/proto-loader": "^0.6.4",
62-
"@types/node": "16.10.0",
62+
"@types/node": ">=12.12.47",
6363
"@types/semver": "^7.3.9"
6464
},
6565
"files": [

packages/grpc-js/src/compression-filter.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,11 +185,13 @@ export class CompressionFilter extends BaseFilter implements Filter {
185185
super();
186186

187187
const compressionAlgorithmKey = channelOptions['grpc.default_compression_algorithm'];
188-
if (isCompressionAlgorithmKey(compressionAlgorithmKey)) {
189-
this.defaultCompressionAlgorithm = CompressionAlgorithms[compressionAlgorithmKey];
190-
this.sendCompression = getCompressionHandler(this.defaultCompressionAlgorithm);
191-
} else {
192-
logging.log(LogVerbosity.ERROR, 'Invalid value provided for grpc.default_compression_algorithm option');
188+
if (compressionAlgorithmKey !== undefined) {
189+
if (isCompressionAlgorithmKey(compressionAlgorithmKey)) {
190+
this.defaultCompressionAlgorithm = CompressionAlgorithms[compressionAlgorithmKey];
191+
this.sendCompression = getCompressionHandler(this.defaultCompressionAlgorithm);
192+
} else {
193+
logging.log(LogVerbosity.ERROR, 'Invalid value provided for grpc.default_compression_algorithm option');
194+
}
193195
}
194196
}
195197

0 commit comments

Comments
 (0)