Skip to content

Commit a9aea45

Browse files
committed
reset process env and add trace log
1 parent 3aaf0c6 commit a9aea45

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

packages/grpc-js/gulpfile.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,17 @@ const testWithAlternativeResolver = checkTask(() => {
9191
);
9292
});
9393

94+
const resetEnv = () => {
95+
process.env.GRPC_NODE_USE_ALTERNATIVE_RESOLVER = 'false';
96+
return Promise.resolve();
97+
};
98+
9499
const test = gulp.series(
95100
install,
96101
copyTestFixtures,
97102
runTests,
98-
testWithAlternativeResolver
103+
testWithAlternativeResolver,
104+
resetEnv
99105
);
100106

101107
export { install, lint, clean, cleanAll, compile, test };

packages/grpc-js/src/resolver-dns.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class DnsResolver implements Resolver {
7373
private isNextResolutionTimerRunning = false;
7474
private isServiceConfigEnabled = true;
7575
private returnedIpResult = false;
76-
private independentResolver = new dns.Resolver();
76+
private alternativeResolver = new dns.Resolver();
7777

7878
constructor(
7979
private target: GrpcUri,
@@ -82,7 +82,7 @@ class DnsResolver implements Resolver {
8282
) {
8383
trace('Resolver constructed for target ' + uriToString(target));
8484
if (target.authority) {
85-
this.independentResolver.setServers([target.authority]);
85+
this.alternativeResolver.setServers([target.authority]);
8686
}
8787
const hostPort = splitHostPort(target.path);
8888
if (hostPort === null) {
@@ -297,9 +297,11 @@ class DnsResolver implements Resolver {
297297

298298
private async lookup(hostname: string): Promise<TcpSubchannelAddress[]> {
299299
if (GRPC_NODE_USE_ALTERNATIVE_RESOLVER) {
300+
trace('Using alternative DNS resolver.');
301+
300302
const records = await Promise.allSettled([
301-
this.independentResolver.resolve4(hostname),
302-
this.independentResolver.resolve6(hostname),
303+
this.alternativeResolver.resolve4(hostname),
304+
this.alternativeResolver.resolve6(hostname),
303305
]);
304306

305307
if (records.every(result => result.status === 'rejected')) {
@@ -328,7 +330,8 @@ class DnsResolver implements Resolver {
328330

329331
private async resolveTxt(hostname: string): Promise<string[][]> {
330332
if (GRPC_NODE_USE_ALTERNATIVE_RESOLVER) {
331-
return this.independentResolver.resolveTxt(hostname);
333+
trace('Using alternative DNS resolver.');
334+
return this.alternativeResolver.resolveTxt(hostname);
332335
}
333336

334337
return dns.resolveTxt(hostname);

0 commit comments

Comments
 (0)