Skip to content

Commit ba375e7

Browse files
committed
Skip a test because it behaves weirdly on Mac
1 parent f706d52 commit ba375e7

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

packages/grpc-js/test/test-resolver.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,15 @@ describe('Name Resolver', () => {
207207
const resolver = resolverManager.createResolver(target, listener, {});
208208
resolver.updateResolution();
209209
});
210-
it('Should resolve a name with multiple dots', done => {
210+
/* The DNS entry for loopback4.unittest.grpc.io only has a single A record
211+
* with the address 127.0.0.1, but the Mac DNS resolver appears to use
212+
* NAT64 to create an IPv6 address in that case, so it instead returns
213+
* 64:ff9b::7f00:1. Handling that kind of translation is outside of the
214+
* scope of this test, so we are skipping it. The test primarily exists
215+
* as a regression test for https://github.com/grpc/grpc-node/issues/1044,
216+
* and the test 'Should resolve gRPC interop servers' tests the same thing.
217+
*/
218+
it.skip('Should resolve a name with multiple dots', done => {
211219
const target = resolverManager.mapUriDefaultScheme(parseUri('loopback4.unittest.grpc.io')!)!;
212220
const listener: resolverManager.ResolverListener = {
213221
onSuccessfulResolution: (
@@ -317,6 +325,10 @@ describe('Name Resolver', () => {
317325
const resolver = resolverManager.createResolver(target, listener, {});
318326
resolver.updateResolution();
319327
});
328+
/* This test also serves as a regression test for
329+
* https://github.com/grpc/grpc-node/issues/1044, specifically handling
330+
* hyphens and multiple periods in a DNS name. It should not be skipped
331+
* unless there is another test for the same issue. */
320332
it('Should resolve gRPC interop servers', done => {
321333
let completeCount = 0;
322334
const target1 = resolverManager.mapUriDefaultScheme(parseUri('grpc-test.sandbox.googleapis.com')!)!;

0 commit comments

Comments
 (0)