Merge pull request #2227 from murgatroid99/grpc-js-xds_nack_0_total_weight

murgatroid99 · web-flow · commit e581aad153a4 · 2022-09-12T16:47:17.000-07:00
grpc-js-xds: NACK WeightedCluster if total_weight is 0
diff --git a/packages/grpc-js-xds/src/xds-stream-state/rds-state.ts b/packages/grpc-js-xds/src/xds-stream-state/rds-state.ts
@@ -89,6 +89,9 @@ export class RdsState extends BaseXdsStreamState<RouteConfiguration__Output> imp
           }
         }
         if (route.route!.cluster_specifier === 'weighted_clusters') {
+          if (route.route.weighted_clusters!.total_weight?.value === 0) {
+            return false;
+          }
           let weightSum = 0;
           for (const clusterWeight of route.route.weighted_clusters!.clusters) {
             weightSum += clusterWeight.weight?.value ?? 0;

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,9 @@ export class RdsState extends BaseXdsStreamState<RouteConfiguration__Output> imp`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`	`if (route.route!.cluster_specifier === 'weighted_clusters') {`
	`92`	`+ if (route.route.weighted_clusters!.total_weight?.value === 0) {`
	`93`	`+ return false;`
	`94`	`+ }`
`92`	`95`	`let weightSum = 0;`
`93`	`96`	`for (const clusterWeight of route.route.weighted_clusters!.clusters) {`
`94`	`97`	`weightSum += clusterWeight.weight?.value ?? 0;`