Skip to content

Commit f3fc8dc

Browse files
authored
Merge pull request #2244 from murgatroid99/grpc-js-xds_drop_v2
grpc-js-xds: Drop xDS v2 support
2 parents 3e0a037 + 4ac8d6d commit f3fc8dc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+174
-3181
lines changed

packages/grpc-js-xds/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"prepare": "npm run compile",
1313
"pretest": "npm run compile",
1414
"posttest": "npm run check",
15-
"generate-types": "proto-loader-gen-types --keepCase --longs String --enums String --defaults --oneofs --includeComments --includeDirs deps/envoy-api/ deps/xds/ deps/googleapis/ deps/protoc-gen-validate/ -O src/generated/ --grpcLib @grpc/grpc-js envoy/service/discovery/v2/ads.proto envoy/service/load_stats/v2/lrs.proto envoy/service/discovery/v3/ads.proto envoy/service/load_stats/v3/lrs.proto envoy/config/listener/v3/listener.proto envoy/config/route/v3/route.proto envoy/config/cluster/v3/cluster.proto envoy/config/endpoint/v3/endpoint.proto envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto udpa/type/v1/typed_struct.proto xds/type/v3/typed_struct.proto envoy/extensions/filters/http/fault/v3/fault.proto envoy/service/status/v3/csds.proto",
15+
"generate-types": "proto-loader-gen-types --keepCase --longs String --enums String --defaults --oneofs --includeComments --includeDirs deps/envoy-api/ deps/xds/ deps/googleapis/ deps/protoc-gen-validate/ -O src/generated/ --grpcLib @grpc/grpc-js envoy/service/discovery/v3/ads.proto envoy/service/load_stats/v3/lrs.proto envoy/config/listener/v3/listener.proto envoy/config/route/v3/route.proto envoy/config/cluster/v3/cluster.proto envoy/config/endpoint/v3/endpoint.proto envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto udpa/type/v1/typed_struct.proto xds/type/v3/typed_struct.proto envoy/extensions/filters/http/fault/v3/fault.proto envoy/service/status/v3/csds.proto",
1616
"generate-interop-types": "proto-loader-gen-types --keep-case --longs String --enums String --defaults --oneofs --json --includeComments --includeDirs proto/ -O interop/generated --grpcLib @grpc/grpc-js grpc/testing/test.proto"
1717
},
1818
"repository": {
@@ -56,7 +56,6 @@
5656
"src/**/*.ts",
5757
"build/src/**/*.{js,d.ts,js.map}",
5858
"deps/envoy-api/envoy/admin/v3/**/*.proto",
59-
"deps/envoy-api/envoy/api/v2/**/*.proto",
6059
"deps/envoy-api/envoy/config/**/*.proto",
6160
"deps/envoy-api/envoy/service/**/*.proto",
6261
"deps/envoy-api/envoy/type/**/*.proto",

packages/grpc-js-xds/src/csds.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { ClientStatusDiscoveryServiceHandlers } from "./generated/envoy/service/
2121
import { ClientStatusRequest__Output } from "./generated/envoy/service/status/v3/ClientStatusRequest";
2222
import { ClientStatusResponse } from "./generated/envoy/service/status/v3/ClientStatusResponse";
2323
import { Timestamp } from "./generated/google/protobuf/Timestamp";
24-
import { AdsTypeUrl, CDS_TYPE_URL_V2, CDS_TYPE_URL_V3, EDS_TYPE_URL_V2, EDS_TYPE_URL_V3, LDS_TYPE_URL_V2, LDS_TYPE_URL_V3, RDS_TYPE_URL_V2, RDS_TYPE_URL_V3 } from "./resources";
24+
import { AdsTypeUrl, CDS_TYPE_URL, EDS_TYPE_URL, LDS_TYPE_URL, RDS_TYPE_URL } from "./resources";
2525
import { HandleResponseResult } from "./xds-stream-state/xds-stream-state";
2626
import { sendUnaryData, ServerDuplexStream, ServerUnaryCall, status, experimental, loadPackageDefinition, logVerbosity } from '@grpc/grpc-js';
2727
import { loadSync } from "@grpc/proto-loader";
@@ -50,14 +50,10 @@ function dateToProtoTimestamp(date?: Date | null): Timestamp | null {
5050
let clientNode: Node | null = null;
5151

5252
const configStatus = {
53-
[EDS_TYPE_URL_V2]: new Map<string, GenericXdsConfig>(),
54-
[EDS_TYPE_URL_V3]: new Map<string, GenericXdsConfig>(),
55-
[CDS_TYPE_URL_V2]: new Map<string, GenericXdsConfig>(),
56-
[CDS_TYPE_URL_V3]: new Map<string, GenericXdsConfig>(),
57-
[RDS_TYPE_URL_V2]: new Map<string, GenericXdsConfig>(),
58-
[RDS_TYPE_URL_V3]: new Map<string, GenericXdsConfig>(),
59-
[LDS_TYPE_URL_V2]: new Map<string, GenericXdsConfig>(),
60-
[LDS_TYPE_URL_V3]: new Map<string, GenericXdsConfig>()
53+
[EDS_TYPE_URL]: new Map<string, GenericXdsConfig>(),
54+
[CDS_TYPE_URL]: new Map<string, GenericXdsConfig>(),
55+
[RDS_TYPE_URL]: new Map<string, GenericXdsConfig>(),
56+
[LDS_TYPE_URL]: new Map<string, GenericXdsConfig>()
6157
};
6258

6359
/**

packages/grpc-js-xds/src/generated/ads.ts

Lines changed: 0 additions & 57 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/grpc-js-xds/src/generated/envoy/api/v2/DeltaDiscoveryRequest.ts

Lines changed: 0 additions & 202 deletions
This file was deleted.

0 commit comments

Comments
 (0)