Skip to content

Commit 02fd7f4

Browse files
committed
PR comments
1 parent 0e3f8b5 commit 02fd7f4

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Sources/GRPCServiceLifecycle/GRPCClient+Service.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
public import GRPCCore
1818
public import ServiceLifecycle
1919

20+
// A `@retroactive` conformance here is okay because this project is also owned by the owners of
21+
// `GRPCCore`, and thus, the owners of `GRPCClient`. A conflicting conformance won't be added.
2022
extension GRPCClient: @retroactive Service {
2123
public func run() async throws {
2224
try await withGracefulShutdownHandler {

Sources/GRPCServiceLifecycle/GRPCServer+Service.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
public import GRPCCore
1818
public import ServiceLifecycle
1919

20+
// A `@retroactive` conformance here is okay because this project is also owned by the owners of
21+
// `GRPCCore`, and thus, the owners of `GRPCServer`. A conflicting conformance won't be added.
2022
extension GRPCServer: @retroactive Service {
2123
public func run() async throws {
2224
try await withGracefulShutdownHandler {

0 commit comments

Comments
 (0)