Skip to content

Commit da06969

Browse files
glbrnttgjcairo
andauthored
Apply suggestions from code review
Co-authored-by: Gus Cairo <[email protected]>
1 parent 99f81a8 commit da06969

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

dev/protos/generate.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ function generate_reflection_service {
9898
local proto="$here/upstream/grpc/reflection/v1/reflection.proto"
9999
local output="$root/Sources/GRPCReflectionService/Generated"
100100

101-
# Messages were accidentally leaked into public API, they shouldn't be but we
102-
# can't undo that change until the next major version.
103101
generate_message "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true"
104102
generate_grpc "$proto" "$(dirname "$proto")" "$output" "Visibility=Package" "UseAccessLevelOnImports=true"
105103
}
@@ -126,7 +124,7 @@ function generate_health_service_descriptor_set {
126124
--include_imports
127125
}
128126

129-
function generate_extended_message_descriptor_set {
127+
function generate_base_message_descriptor_set {
130128
local proto="$here/tests/reflection/base_message.proto"
131129
local proto_path="$here/tests/reflection"
132130
local output="$root/Tests/GRPCReflectionServiceTests/Generated/DescriptorSets/base_message.pb"
@@ -154,5 +152,5 @@ generate_reflection_service
154152

155153
generate_reflection_service_descriptor_set
156154
generate_health_service_descriptor_set
157-
generate_extended_message_descriptor_set
155+
generate_base_message_descriptor_set
158156
generate_message_with_dependency_descriptor_set

0 commit comments

Comments
 (0)