Skip to content

Commit 8ab76b8

Browse files
committed
Fix tests are changes in core
Motivation: We changed some names in the code gen lib in grpc-swift. Modifications: Use newer naming. Result: Compiles against main
1 parent c7ab0b3 commit 8ab76b8

File tree

3 files changed

+36
-35
lines changed

3 files changed

+36
-35
lines changed

Sources/GRPCProtobufCodeGen/ProtobufCodeGenParser.swift

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
*/
1616

1717
internal import Foundation
18+
internal import GRPCCodeGen
1819
internal import SwiftProtobufPluginLibrary
1920

20-
internal import struct GRPCCodeGen.CodeGenerationRequest
21-
internal import struct GRPCCodeGen.SourceGenerator
22-
2321
/// Parses a ``FileDescriptor`` object into a ``CodeGenerationRequest`` object.
2422
internal struct ProtobufCodeGenParser {
2523
let input: FileDescriptor
@@ -68,7 +66,7 @@ internal struct ProtobufCodeGenParser {
6866
"GRPCProtobuf.ProtobufDeserializer<\(messageType)>()"
6967
}
7068
let services = self.input.services.map {
71-
CodeGenerationRequest.ServiceDescriptor(
69+
ServiceDescriptor(
7270
descriptor: $0,
7371
package: input.package,
7472
protobufNamer: self.namer,
@@ -88,41 +86,41 @@ internal struct ProtobufCodeGenParser {
8886
}
8987

9088
extension ProtobufCodeGenParser {
91-
fileprivate var codeDependencies: [CodeGenerationRequest.Dependency] {
92-
var codeDependencies: [CodeGenerationRequest.Dependency] = [
89+
fileprivate var codeDependencies: [Dependency] {
90+
var codeDependencies: [Dependency] = [
9391
.init(module: "GRPCProtobuf", accessLevel: .internal)
9492
]
9593
// Adding as dependencies the modules containing generated code or types for
9694
// '.proto' files imported in the '.proto' file we are parsing.
9795
codeDependencies.append(
9896
contentsOf: (self.protoToModuleMappings.neededModules(forFile: self.input) ?? []).map {
99-
CodeGenerationRequest.Dependency(module: $0, accessLevel: self.accessLevel)
97+
Dependency(module: $0, accessLevel: self.accessLevel)
10098
}
10199
)
102100
// Adding extra imports passed in as an option to the plugin.
103101
codeDependencies.append(
104102
contentsOf: self.extraModuleImports.sorted().map {
105-
CodeGenerationRequest.Dependency(module: $0, accessLevel: self.accessLevel)
103+
Dependency(module: $0, accessLevel: self.accessLevel)
106104
}
107105
)
108106
return codeDependencies
109107
}
110108
}
111109

112-
extension CodeGenerationRequest.ServiceDescriptor {
110+
extension GRPCCodeGen.ServiceDescriptor {
113111
fileprivate init(
114-
descriptor: ServiceDescriptor,
112+
descriptor: SwiftProtobufPluginLibrary.ServiceDescriptor,
115113
package: String,
116114
protobufNamer: SwiftProtobufNamer,
117115
file: FileDescriptor
118116
) {
119117
let methods = descriptor.methods.map {
120-
CodeGenerationRequest.ServiceDescriptor.MethodDescriptor(
118+
GRPCCodeGen.MethodDescriptor(
121119
descriptor: $0,
122120
protobufNamer: protobufNamer
123121
)
124122
}
125-
let name = CodeGenerationRequest.Name(
123+
let name = Name(
126124
base: descriptor.name,
127125
// The service name from the '.proto' file is expected to be in upper camel case
128126
generatedUpperCase: descriptor.name,
@@ -131,7 +129,7 @@ extension CodeGenerationRequest.ServiceDescriptor {
131129

132130
// Packages that are based on the path of the '.proto' file usually
133131
// contain dots. For example: "grpc.test".
134-
let namespace = CodeGenerationRequest.Name(
132+
let namespace = Name(
135133
base: package,
136134
generatedUpperCase: protobufNamer.formattedUpperCasePackage(file: file),
137135
generatedLowerCase: protobufNamer.formattedLowerCasePackage(file: file)
@@ -141,9 +139,12 @@ extension CodeGenerationRequest.ServiceDescriptor {
141139
}
142140
}
143141

144-
extension CodeGenerationRequest.ServiceDescriptor.MethodDescriptor {
145-
fileprivate init(descriptor: MethodDescriptor, protobufNamer: SwiftProtobufNamer) {
146-
let name = CodeGenerationRequest.Name(
142+
extension GRPCCodeGen.MethodDescriptor {
143+
fileprivate init(
144+
descriptor: SwiftProtobufPluginLibrary.MethodDescriptor,
145+
protobufNamer: SwiftProtobufNamer
146+
) {
147+
let name = Name(
147148
base: descriptor.name,
148149
// The method name from the '.proto' file is expected to be in upper camel case
149150
generatedUpperCase: descriptor.name,

Tests/GRPCProtobufCodeGenTests/ProtobufCodeGenParserTests.swift

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ final class ProtobufCodeGenParserTests: XCTestCase {
6161

6262
self.testCommonHelloworldParsedRequestFields(for: parsedCodeGenRequest)
6363

64-
let expectedMethod = CodeGenerationRequest.ServiceDescriptor.MethodDescriptor(
64+
let expectedMethod = MethodDescriptor(
6565
documentation: "/// Sends a greeting.\n",
66-
name: CodeGenerationRequest.Name(
66+
name: Name(
6767
base: "SayHello",
6868
generatedUpperCase: "SayHello",
6969
generatedLowerCase: "sayHello"
@@ -76,14 +76,14 @@ final class ProtobufCodeGenParserTests: XCTestCase {
7676
guard let method = parsedCodeGenRequest.services.first?.methods.first else { return XCTFail() }
7777
XCTAssertEqual(method, expectedMethod)
7878

79-
let expectedService = CodeGenerationRequest.ServiceDescriptor(
79+
let expectedService = ServiceDescriptor(
8080
documentation: "/// The greeting service definition.\n",
81-
name: CodeGenerationRequest.Name(
81+
name: Name(
8282
base: "Greeter",
8383
generatedUpperCase: "Greeter",
8484
generatedLowerCase: "greeter"
8585
),
86-
namespace: CodeGenerationRequest.Name(
86+
namespace: Name(
8787
base: "helloworld",
8888
generatedUpperCase: "Helloworld",
8989
generatedLowerCase: "helloworld"
@@ -143,9 +143,9 @@ final class ProtobufCodeGenParserTests: XCTestCase {
143143

144144
self.testCommonHelloworldParsedRequestFields(for: parsedCodeGenRequest)
145145

146-
let expectedMethod = CodeGenerationRequest.ServiceDescriptor.MethodDescriptor(
146+
let expectedMethod = MethodDescriptor(
147147
documentation: "/// Sends a greeting.\n",
148-
name: CodeGenerationRequest.Name(
148+
name: Name(
149149
base: "SayHello",
150150
generatedUpperCase: "SayHello",
151151
generatedLowerCase: "sayHello"
@@ -158,14 +158,14 @@ final class ProtobufCodeGenParserTests: XCTestCase {
158158
guard let method = parsedCodeGenRequest.services.first?.methods.first else { return XCTFail() }
159159
XCTAssertEqual(method, expectedMethod)
160160

161-
let expectedService = CodeGenerationRequest.ServiceDescriptor(
161+
let expectedService = ServiceDescriptor(
162162
documentation: "/// The greeting service definition.\n",
163-
name: CodeGenerationRequest.Name(
163+
name: Name(
164164
base: "Greeter",
165165
generatedUpperCase: "Greeter",
166166
generatedLowerCase: "greeter"
167167
),
168-
namespace: CodeGenerationRequest.Name(
168+
namespace: Name(
169169
base: "hello.world",
170170
generatedUpperCase: "Hello_World",
171171
generatedLowerCase: "hello_world"
@@ -225,9 +225,9 @@ final class ProtobufCodeGenParserTests: XCTestCase {
225225

226226
self.testCommonHelloworldParsedRequestFields(for: parsedCodeGenRequest)
227227

228-
let expectedMethod = CodeGenerationRequest.ServiceDescriptor.MethodDescriptor(
228+
let expectedMethod = MethodDescriptor(
229229
documentation: "/// Sends a greeting.\n",
230-
name: CodeGenerationRequest.Name(
230+
name: Name(
231231
base: "SayHello",
232232
generatedUpperCase: "SayHello",
233233
generatedLowerCase: "sayHello"
@@ -240,14 +240,14 @@ final class ProtobufCodeGenParserTests: XCTestCase {
240240
guard let method = parsedCodeGenRequest.services.first?.methods.first else { return XCTFail() }
241241
XCTAssertEqual(method, expectedMethod)
242242

243-
let expectedService = CodeGenerationRequest.ServiceDescriptor(
243+
let expectedService = ServiceDescriptor(
244244
documentation: "/// The greeting service definition.\n",
245-
name: CodeGenerationRequest.Name(
245+
name: Name(
246246
base: "Greeter",
247247
generatedUpperCase: "Greeter",
248248
generatedLowerCase: "greeter"
249249
),
250-
namespace: CodeGenerationRequest.Name(
250+
namespace: Name(
251251
base: "",
252252
generatedUpperCase: "",
253253
generatedLowerCase: ""

Tests/GRPCProtobufCodeGenTests/ProtobufCodeGeneratorTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,11 @@ final class ProtobufCodeGeneratorTests: XCTestCase {
146146
@available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
147147
internal struct Hello_World_Greeter_Client: Hello_World_Greeter.ClientProtocol {
148148
private let client: GRPCCore.GRPCClient
149-
149+
150150
internal init(wrapping client: GRPCCore.GRPCClient) {
151151
self.client = client
152152
}
153-
153+
154154
/// Sends a greeting.
155155
internal func sayHello<R>(
156156
request: GRPCCore.ClientRequest<Hello_World_HelloRequest>,
@@ -473,11 +473,11 @@ final class ProtobufCodeGeneratorTests: XCTestCase {
473473
@available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
474474
package struct Greeter_Client: Greeter.ClientProtocol {
475475
private let client: GRPCCore.GRPCClient
476-
476+
477477
package init(wrapping client: GRPCCore.GRPCClient) {
478478
self.client = client
479479
}
480-
480+
481481
/// Sends a greeting.
482482
package func sayHello<R>(
483483
request: GRPCCore.ClientRequest<HelloRequest>,

0 commit comments

Comments
 (0)