Skip to content

Commit 9b79693

Browse files
authored
Ignore case for boolean option values in protoc-gen-grpc-swift (#20)
Motivation: The protoc-gen-grpc-swift plugin has a few boolean options which currently require a lowercased value. This is overly strict, the casing of "true"/"false" shouldn't matter. Modifications: - Ignore case for boolean optioned values Result: Easier to use protoc-gen-grpc-swift
1 parent af08da4 commit 9b79693

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Sources/protoc-gen-grpc-swift/Options.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ struct GeneratorOptions {
8888
}
8989

9090
case "Server":
91-
if let value = Bool(pair.value) {
91+
if let value = Bool(pair.value.lowercased()) {
9292
self.generateServer = value
9393
} else {
9494
throw GenerationError.invalidParameterValue(name: pair.key, value: pair.value)
9595
}
9696

9797
case "Client":
98-
if let value = Bool(pair.value) {
98+
if let value = Bool(pair.value.lowercased()) {
9999
self.generateClient = value
100100
} else {
101101
throw GenerationError.invalidParameterValue(name: pair.key, value: pair.value)
@@ -142,14 +142,14 @@ struct GeneratorOptions {
142142
}
143143

144144
case "ReflectionData":
145-
if let value = Bool(pair.value) {
145+
if let value = Bool(pair.value.lowercased()) {
146146
self.generateReflectionData = value
147147
} else {
148148
throw GenerationError.invalidParameterValue(name: pair.key, value: pair.value)
149149
}
150150

151151
case "UseAccessLevelOnImports":
152-
if let value = Bool(pair.value) {
152+
if let value = Bool(pair.value.lowercased()) {
153153
self.useAccessLevelOnImports = value
154154
} else {
155155
throw GenerationError.invalidParameterValue(name: pair.key, value: pair.value)

0 commit comments

Comments
 (0)