Skip to content

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 24, 2024

Motivation:

We should have a README to explain what the package is and should point to docs we publish to the Swift Package Index.

Modifications:

  • Add a README
  • Add a .spi.yml
  • Add a DocC catalog

Result:

More docs

Motivation:

We should have a README to explain what the package is and should point
to docs we publish to the Swift Package Index.

Modifications:

- Add a README
- Add a .spi.yml
- Add a DocC catalog

Result:

More docs
@glbrntt glbrntt requested a review from gjcairo September 24, 2024 14:31
@glbrntt glbrntt added the semver/none No version bump required. label Sep 24, 2024
@glbrntt glbrntt enabled auto-merge (squash) September 25, 2024 14:12
Comment on lines +19 to +20
- ``ProtobufSerializer``
- ``ProtobufDeserializer``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want some more detail here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we're just listing links to types (these are the only ones) – DocC renders a summary of each inline:

Screenshot 2024-09-30 at 11 13 46

`grpc-swift` documentation on the [Swift Package
Index](https://swiftpackageindex.com/grpc/grpc-swift/documentation).

## Topics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this empty section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: if you don't have a ## Topic, DocC will insert it for you at the end of the doc.

Co-authored-by: Gus Cairo <[email protected]>
@glbrntt glbrntt requested a review from gjcairo September 30, 2024 10:14
@glbrntt glbrntt merged commit f89495e into grpc:main Sep 30, 2024
3 of 4 checks passed
@glbrntt glbrntt deleted the add-docs branch September 30, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants