Rename to add(contentsOf:)

Author: gjcairo

Sources/GRPCCore/Metadata.swift

@@ -171,13 +171,11 @@ public struct Metadata: Sendable, Hashable {
     self.elements.append(.init(key: key, value: value))
   }
 
-  /// Merge another instance of `Metadata` into this one.
+  /// Add the contents of a `Sequence` of key-value pairs to this `Metadata` instance.
   ///
-  /// - Parameter other: the `Metadata` which key-value pairs should be merged into this one.
-  public mutating func merge(_ other: Metadata) {
-    for (key, value) in other {
-      self.addValue(value, forKey: key)
-    }
+  /// - Parameter other: the `Sequence` whose key-value pairs should be added into this `Metadata` instance.
+  public mutating func add(contentsOf other: some Sequence<Element>) {
+    self.elements.append(contentsOf: other.map(KeyValuePair.init))
   }
 
   /// Removes all values associated with the given key.

Tests/GRPCCoreTests/MetadataTests.swift

@@ -268,7 +268,7 @@ struct MetadataTests {
     @Test("Where key is already present with a different value")
     mutating func mergeWhereKeyIsAlreadyPresentWithDifferentValue() async throws {
       self.otherMetadata.addString("value1-2", forKey: "key1")
-      self.metadata.merge(self.otherMetadata)
+      self.metadata.add(contentsOf: self.otherMetadata)
 
       #expect(self.metadata == [
         "key1": "value1-1",
@@ -283,7 +283,7 @@ struct MetadataTests {
     @Test("Where key is already present with same value")
     mutating func mergeWhereKeyIsAlreadyPresentWithSameValue() async throws {
       self.otherMetadata.addString("value1-1", forKey: "key1")
-      self.metadata.merge(self.otherMetadata)
+      self.metadata.add(contentsOf: self.otherMetadata)
 
       #expect(self.metadata == [
         "key1": "value1-1",
@@ -297,7 +297,7 @@ struct MetadataTests {
 
     @Test("Where key is not already present")
     mutating func mergeWhereKeyIsNotAlreadyPresent() async throws {
-      self.metadata.merge(self.otherMetadata)
+      self.metadata.add(contentsOf: self.otherMetadata)
 
       #expect(self.metadata == [
         "key1": "value1-1",