Skip to content

Commit 31dfa48

Browse files
authored
Apply suggestions from code review
1 parent 03aafc5 commit 31dfa48

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Sources/GRPCCore/Documentation.docc/Articles/Generating-stubs.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ You may use the build plugin either from the command line or from Xcode.
1717

1818
The build plugin (`GRPCProtobufGenerator`) is a great choice for convenient dynamic code generation, however it does come with some limitations.
1919
Because it generates the gRPC Swift stubs as part of the build it has the requirement that `protoc` must be available
20-
at compile time. This requirements means it is not a good fit for library authors who do not have
20+
at compile time. This requirement means it is not a good fit for library authors who do not have
2121
direct control over this.
2222

2323
The build plugin detects `.proto` files in the source tree and invokes `protoc` once for each file
@@ -43,7 +43,7 @@ targets: [
4343
)
4444
]
4545
```
46-
Once this is done you need to ensure that that the `.proto` files to be used for generation
46+
Once this is done you need to ensure that the `.proto` files to be used for generation
4747
are included in the target's source directory and that you have defined at least one configuration file.
4848

4949
### Configuration
@@ -80,8 +80,8 @@ The options do not need to be specified and each have default values.
8080
| `generate.messages` | `true`, `false` | `true` | Generate message stubs |
8181
| `generatedSource.accessLevelOnImports` | `true`, `false` | `false` | Whether imports should have explicit access levels |
8282
| `generatedSource.accessLevel` | `"public"`, `"package"`, `"internal"` | `"internal"` | Access level for generated stubs |
83-
| `protoc.executablePath` | N/A | null | Path to the `protoc` executable |
84-
| `protoc.importPaths` | N/A | null | Import paths passed to `protoc` |
83+
| `protoc.executablePath` | N/A | `null` | Path to the `protoc` executable |
84+
| `protoc.importPaths` | N/A | `null` | Import paths passed to `protoc` |
8585

8686
† The Swift Package Manager build plugin infrastructure will attempt to discover the executable's location if you don't provide one.
8787

0 commit comments

Comments
 (0)