PR changes

Author: gjcairo

Sources/GRPCCore/Metadata.swift

@@ -494,20 +494,29 @@ extension Metadata.Value: ExpressibleByArrayLiteral {
 
 extension Metadata: CustomStringConvertible {
   public var description: String {
-    var description = "["
-    description = self.dropLast().reduce(into: description) { partialResult, nextPair in
-      partialResult += "\"\(nextPair.key)\": \(nextPair.value), "
+    if self.isEmpty {
+      return "[:]"
+    } else {
+      let elements = self.map { "\(String(reflecting: $0.key)): \(String(reflecting: $0.value))"}
+        .joined(separator: ", ")
+      return "[\(elements)]"
     }
-    if let lastElement = self.last {
-      description += "\"\(lastElement.key)\": \(lastElement.value)"
-    }
-    description += "]"
-    return description
   }
 }
 
 extension Metadata.Value: CustomStringConvertible {
   public var description: String {
+    switch self {
+    case .string(let stringValue):
+      return stringValue
+    case .binary(let binaryValue):
+      return String(describing: binaryValue)
+    }
+  }
+}
+
+extension Metadata.Value: CustomDebugStringConvertible {
+  public var debugDescription: String {
     switch self {
     case .string(let stringValue):
       return "\"\(stringValue)\""

Tests/GRPCCoreTests/MetadataTests.swift

@@ -324,7 +324,21 @@ struct MetadataTests {
         "key2": "value2",
         "key-bin": .binary([1, 2, 3]),
       ]
+
       #expect("\(metadata)" == #"["key1": "value1", "key2": "value2", "key-bin": [1, 2, 3]]"#)
+
+      for (key, value) in metadata {
+        switch key {
+        case "key1":
+          #expect("\(value)" == "value1")
+        case "key2":
+          #expect("\(value)" == "value2")
+        case "key-bin":
+          #expect("\(value)" == "[1, 2, 3]")
+        default:
+          Issue.record("Should not have reached this point")
+        }
+      }
     }
   }
 }