Skip to content

Commit a313fcf

Browse files
authored
Fix soundness script (#1676)
Motivation: The formatting script expects the '-l' flag to run the lint checker without running the formatter. The soundness script pass 'lint' which was ignored, so the script ran the formatter instead of the lint checker which means the formatting checker will never fail in CI. Modifications: - Fix the incorrect flag - Fix a formatting issue which crept in Result: CI checks formatting correctly...
1 parent 5e8afe9 commit a313fcf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Tests/GRPCTests/InterceptedRPCCancellationTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,10 @@ final class MagicAddingClientInterceptor<
170170
interceptors: []
171171
)
172172

173-
self.retry!.invoke(onError: {
173+
self.retry!.invoke {
174174
context.log.debug("intercepting error from retried rpc")
175175
context.errorCaught($0)
176-
}) { responsePart in
176+
} onResponsePart: { responsePart in
177177
context.log.debug("intercepting response part from retried rpc")
178178
context.receive(responsePart)
179179
}

scripts/sanity.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function check_license_headers() {
4242
}
4343

4444
function check_formatting() {
45-
run_logged "Checking formatting" "$HERE/format.sh lint"
45+
run_logged "Checking formatting" "$HERE/format.sh -l"
4646
}
4747

4848
errors=0

0 commit comments

Comments
 (0)