Commit f384235
authored
Make testRetriesEventuallySucceed more reliable (#1779)
Motivation:
`testRetriesEventuallySucceed` fails infrequently. When attempting a
retry, the executor checks whether it's safe for the broadcast sequence
to be replayed, it does so after removing all subscribers. However,
there is a timing window between invalidating subscribers and checking
whether it's safe in which a subscribtion can be registered. For
retries, this can happen if the server responds before the client has
subscribed. In practice this is very unlikely to happen because of
network latency.
Modifications:
Have the server in the test consume the inbound stream before failing,
this ensures the subscribtion is created by the time the client realises
the call has failed.
Result:
Test passes more reliably1 parent 7bb2506 commit f384235
File tree
1 file changed
+5
-1
lines changed- Tests/GRPCCoreTests/Call/Client/Internal
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
42 | 46 | | |
43 | 47 | | |
44 | 48 | | |
| |||
0 commit comments