-
Notifications
You must be signed in to change notification settings - Fork 436
Closed
Labels
kind/bugFeature doesn't work as expected.Feature doesn't work as expected.
Description
Describe the bug
When downloading archives from the 1.23.0
GitHub release, the included version of protoc-gen-swift
differs between the macOS and Linux versions:
- The Linux version (https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-linux-x86_64-1.23.0.zip) contains
protoc-gen-swift 1.26.0
- The macOS version (https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-1.23.0.zip) contains
protoc-gen-swift 1.25.1
This is leading to us seeing different generated output under CI vs. when run locally.
To reproduce
See this reproduction repo / workflow run: https://github.com/ezzatron/grpc-swift-binary-version-repro/actions/runs/10804792826
Alternatively, set up a GitHub repo with this workflow, and run it to check the version difference:
on:
push:
jobs:
linux:
runs-on: ubuntu-latest
steps:
- run: |
curl -sSL https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-linux-x86_64-1.23.0.zip -o protoc-grpc-swift-plugins.zip
unzip protoc-grpc-swift-plugins.zip
./protoc-gen-swift --version
./protoc-gen-grpc-swift --version
macos:
runs-on: macos-latest
steps:
- run: |
curl -sSL https://github.com/grpc/grpc-swift/releases/download/1.23.0/protoc-grpc-swift-plugins-1.23.0.zip -o protoc-grpc-swift-plugins.zip
unzip protoc-grpc-swift-plugins.zip
bin/protoc-gen-swift --version
bin/protoc-gen-grpc-swift --version
Expected behaviour
The version of protoc-gen-swift
should be the same across all architectures for a given release.
Additional information
N/A
Metadata
Metadata
Assignees
Labels
kind/bugFeature doesn't work as expected.Feature doesn't work as expected.