Add support for starting a server from accepted conns #2260
+475
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
already-accepted
branch
from
8475c88 to
1f0d07c
Compare
Motivation: Some applications receive a file descriptor for an already accepted TCP connection. There's currently no API to create a server from an fd like this. Modifications: - Add an API to the server builder allowing a server to be created from an accepted socket - Add tests Result: Can create a server from an accepted socket fd
glbrntt
force-pushed
the
already-accepted
branch
from
1f0d07c to
7a6a4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some applications receive a file descriptor for an already accepted TCP connection. There's currently no API to create a server from an fd like this.
Modifications:
Result:
Can create a server from an accepted socket fd