-
Notifications
You must be signed in to change notification settings - Fork 96
Description
Hi, I found an interesting case in this project.
It has “Thread.sleep()” in a “while(true)” loop. I found some discussion in Stackoverflow and other website. It can be refactored by using a executor service.
https://ejrh.wordpress.com/2012/07/13/sleeping-in-loops-considered-harmful/
https://stackoverflow.com/questions/3535754/netbeans-java-new-hint-thread-sleep-called-in-loop
or
Maybe use CountDownLatch.await to automatically awake and shutdown.
Detailed websites and lines:
47 | https://github.com/grundid/nfctools/blob/master/nfctools-core/src/main/java/org/nfctools/spi/acs/PollingCardScanner.java
53 | https://github.com/grundid/nfctools/blob/master/nfctools-core/src/main/java/org/nfctools/spi/acs/AbstractTerminalTagScanner.java
116 | https://github.com/grundid/nfctools/blob/master/nfctools-core/src/main/java/org/nfctools/spi/acs/AcsTerminal.java
Best regards