refactor: add type-safe WrapGcpInitClient helper for GCP resources

- Add WrapGcpInitClient helper matching AWS's WrapAwsInitClient pattern
- Add GCP constants (DefaultBatchSize, DefaultWaitTimeout) for consistency
- Improve GCP adapter documentation to match AWS quality
- Update gcs_bucket.go to use WrapGcpInitClient with proper error handling
- Replace silent failures with panics for programming errors

Author: james00012

gcp/resources/adapter.go

@@ -2,12 +2,33 @@ package resources
 
 import (
 	"context"
+	"fmt"
+	"time"
 
 	"github.com/gruntwork-io/cloud-nuke/resource"
 )
 
+const (
+	DefaultWaitTimeout = 5 * time.Minute
+	DefaultBatchSize   = 50
+)
+
+// GcpInitClientFunc is the type-safe client initialization function signature.
+type GcpInitClientFunc[C any] func(r *resource.Resource[C], projectID string)
+
+// WrapGcpInitClient converts a GcpInitClientFunc to the generic InitClient signature.
+// Panics on type assertion failure since that indicates a programming error.
+func WrapGcpInitClient[C any](fn GcpInitClientFunc[C]) func(r *resource.Resource[C], cfg any) {
+	return func(r *resource.Resource[C], cfg any) {
+		projectID, ok := cfg.(string)
+		if !ok {
+			panic(fmt.Sprintf("WrapGcpInitClient: expected string projectID, got %T", cfg))
+		}
+		fn(r, projectID)
+	}
+}
+
 // GcpResourceAdapter wraps a generic Resource to satisfy the GcpResource interface.
-// It provides type-safe Init(string) for GCP's project ID initialization.
 type GcpResourceAdapter[C any] struct {
 	*resource.Resource[C]
 }
@@ -27,5 +48,4 @@ func (g *GcpResourceAdapter[C]) Nuke(ctx context.Context, identifiers []string)
 	return g.Resource.Nuke(ctx, identifiers)
 }
 
-// Compile-time interface satisfaction check
 var _ GcpResource = (*GcpResourceAdapter[any])(nil)

gcp/resources/gcs_bucket.go

@@ -18,21 +18,15 @@ import (
 func NewGCSBuckets() GcpResource {
 	return NewGcpResource(&resource.Resource[*storage.Client]{
 		ResourceTypeName: "gcs-bucket",
-		BatchSize:        50,
-		InitClient: func(r *resource.Resource[*storage.Client], cfg any) {
-			projectID, ok := cfg.(string)
-			if !ok {
-				logging.Debugf("Invalid config type for GCS client: expected string")
-				return
-			}
+		BatchSize:        DefaultBatchSize,
+		InitClient: WrapGcpInitClient(func(r *resource.Resource[*storage.Client], projectID string) {
 			r.Scope.ProjectID = projectID
 			client, err := storage.NewClient(context.Background())
 			if err != nil {
-				logging.Debugf("Failed to create GCS client: %v", err)
-				return
+				panic(fmt.Sprintf("failed to create GCS client: %v", err))
 			}
 			r.Client = client
-		},
+		}),
 		ConfigGetter: func(c config.Config) config.ResourceType {
 			return c.GCSBucket
 		},