Merge pull request #15 from Tensho/terraform-validate

Add "terraform-validate" Hook

Author: yorinasub17

.pre-commit-hooks.yaml

@@ -2,11 +2,21 @@
 
 - id: terraform-fmt
   name: Terraform fmt
-  description: Rewrites all Terraform configuration files to a canonical format.
+  description: Rewrites all Terraform configuration files to a canonical format
   entry: hooks/terraform-fmt.sh
   language: script
   files: \.tf$
   exclude: \.+.terraform\/.*$
+  require_serial: true
+
+- id: terraform-validate
+  name: Terraform validate
+  description: Validates all Terraform configuration files
+  entry: hooks/terraform-validate.sh
+  language: script
+  files: \.tf$
+  exclude: \.+.terraform\/.*$
+  require_serial: true
 
 - id: shellcheck
   name: Shellcheck Bash Linter
@@ -16,7 +26,7 @@
 
 - id: gofmt
   name: gofmt
-  description: Gofmt formats Go programs.
+  description: Gofmt formats Go programs
   entry: hooks/gofmt.sh
   language: script
   files: \.go$
@@ -32,15 +42,15 @@
 
 - id: golint
   name: golint
-  description: Golint is a linter for Go source code.
+  description: Golint is a linter for Go source code
   entry: hooks/golint.sh
   language: script
   files: \.go$
   exclude: vendor\/.*$
 
 - id: yapf
   name: yapf
-  description: yapf (Yet Another Python Formatter) is a python formatter from Google.
+  description: yapf (Yet Another Python Formatter) is a python formatter from Google
   entry: hooks/yapf.sh
   language: script
   files: \.py$

README.md

@@ -6,6 +6,7 @@ This repo defines Git pre-commit hooks intended for use with [pre-commit](http:/
 supported hooks are:
 
 * **terraform-fmt**: Automatically run `terraform fmt` on all Terraform code (`*.tf` files).
+* **terraform-validate**: Automatically run `terraform validate` on all Terraform code (`*.tf` files).
 * **shellcheck**: Run [`shellcheck`](https://www.shellcheck.net/) to lint files that contain a bash [shebang](https://en.wikipedia.org/wiki/Shebang_(Unix))
 * **gofmt**: Automatically run `gofmt` on all Golang code (`*.go` files).
 * **golint**: Automatically run `golint` on all Golang code (`*.go` files)
@@ -26,6 +27,7 @@ repos:
     rev: <VERSION> # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
     hooks:
       - id: terraform-fmt
+      - id: terraform-validate
       - id: shellcheck
       - id: gofmt
       - id: golint

hooks/terraform-fmt.sh

@@ -7,6 +7,4 @@ set -e
 # workaround to allow GitHub Desktop to work, add this (hopefully harmless) setting here.
 export PATH=$PATH:/usr/local/bin
 
-for file in "$@"; do
-  terraform fmt `dirname $file`
-done
+terraform fmt -recursive

hooks/terraform-validate.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+set -e
+
+# OSX GUI apps do not pick up environment variables the same way as Terminal apps and there are no easy solutions,
+# especially as Apple changes the GUI app behavior every release (see https://stackoverflow.com/q/135688/483528). As a
+# workaround to allow GitHub Desktop to work, add this (hopefully harmless) setting here.
+export PATH=$PATH:/usr/local/bin
+
+for dir in $(echo "$@" | xargs -n1 dirname | sort -u | uniq); do
+  terraform init -backend=false $dir
+  terraform validate $dir
+done