feat: Adding lint.yml and strict-lint.yml workflows for GitHub Actions (#4172)

* feat: Adding `lint.yml` and `strict-lint.yml` workflows for GitHub Actions

* feat: Use Makefile recipes

* fix: Also run on push to `main`

Author: yhakbar

.circleci/config.yml

@@ -237,11 +237,6 @@ jobs:
           command: |
             make install-mockery
             make generate-mocks
-      - run:
-          name: run lint
-          command: |
-            make install-lint
-            make run-lint
       - run:
           command: |
             mkdir -p logs
@@ -561,20 +556,6 @@ jobs:
       - store_test_results:
           path: logs
 
-  strict_lint:
-    resource_class: medium
-    <<: *defaults
-    <<: *env
-    steps:
-      - checkout
-      # The `run-strict-lint` target requires the `main` ref for comparison.
-      - run: git fetch
-      - run:
-          name: Run strict lint
-          command: |
-            make install-lint
-            make run-strict-lint
-
   # Run TFLint tests separately as tflint during execution change working directory.
   integration_test_tflint:
     resource_class: large
@@ -1024,15 +1005,3 @@ workflows:
             - GCP__automated-tests
             - GITHUB__PAT__gruntwork-ci
             - APPLE__OSX__code-signing
-  unessential:
-    jobs:
-      - strict_lint:
-          filters:
-            tags:
-              only:
-                - /^v.*/
-                - /^alpha.*/
-          context:
-            - AWS__PHXDEVOPS__circle-ci-test
-            - GCP__automated-tests
-            - GITHUB__PAT__gruntwork-ci

.github/workflows/build-no-proxy.yml

@@ -1,12 +1,15 @@
 name: Build Without Go Proxy
 
 on:
+  push:
+    branches:
+      - main
   pull_request:
     types: [opened, synchronize, reopened]
 
 jobs:
   build-no-proxy:
-    name: Build Without Go Proxy (${{ matrix.os }}/${{ matrix.arch }})
+    name: Build (${{ matrix.os }}/${{ matrix.arch }})
     runs-on: ubuntu-latest
     strategy:
       matrix:

.github/workflows/lint.yml

@@ -0,0 +1,49 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up mise
+      uses: jdx/mise-action@v2
+      with:
+        version: 2025.4.4
+
+    - id: go-cache-paths
+      run: |
+        echo "go-build=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
+        echo "go-mod=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT"
+
+        # TODO: Make this less brittle.
+        echo "golanci-lint-cache=/home/runner/.cache/golangci-lint" >> "$GITHUB_OUTPUT"
+
+    - name: Go Build Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.go-build }}
+        key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
+
+    - name: Go Mod Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.go-mod }}
+        key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
+
+    - name: golangci-lint Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.golanci-lint-cache }}
+        key: ${{ runner.os }}-golangci-lint-${{ hashFiles('**/go.sum') }}
+
+    - name: Lint
+      run: make run-lint

.github/workflows/strict-lint.yml

@@ -0,0 +1,46 @@
+name: Strict Lint
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up mise
+      uses: jdx/mise-action@v2
+      with:
+        version: 2025.4.4
+
+    - id: go-cache-paths
+      run: |
+        echo "go-build=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
+        echo "go-mod=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT"
+
+        # TODO: Make this less brittle.
+        echo "golanci-lint-cache=/home/runner/.cache/golangci-lint" >> "$GITHUB_OUTPUT"
+
+    - name: Go Build Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.go-build }}
+        key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
+
+    - name: Go Mod Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.go-mod }}
+        key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
+
+    - name: golangci-lint Cache
+      uses: actions/cache@v4
+      with:
+        path: ${{ steps.go-cache-paths.outputs.golanci-lint-cache }}
+        key: ${{ runner.os }}-golangci-lint-${{ hashFiles('**/go.sum') }}
+
+    - name: Lint
+      run: make run-strict-lint

mise.toml

@@ -1,3 +1,4 @@
 [tools]
 go = "1.23.8"
 opentofu = "1.9.0"
+golangci-lint = "1.64.6"